Moved macros into prtime.h

base/third_party/nspr/prtime.h

 /* Portions are Copyright (C) 2011 Google Inc */
 /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
  * 1.1 (the "License"); you may not use this file except in compliance with
  * the License. You may obtain a copy of the License at
  * http://www.mozilla.org/MPL/
  *
  * Software distributed under the License is distributed on an "AS IS" basis,
@@ skipping 53 matching lines @@
 
 typedef PRIntn PRBool;
 #define PR_TRUE 1
 #define PR_FALSE 0
 
 typedef enum { PR_FAILURE = -1, PR_SUCCESS = 0 } PRStatus;
 
 #define PR_ASSERT DCHECK
 #define PR_CALLBACK
 #define PR_INT16_MAX 32767
 #define NSPR_API(__type) extern __type

[wtc, 2016/02/20 01:05:16]

Please add the new macros here.

[pkl (ping after 24h if needed), 2016/02/20 07:28:49]

Acknowledged.

 
 /**********************************************************************/
 /************************* TYPES AND CONSTANTS ************************/
 /**********************************************************************/
 
 #define PR_MSEC_PER_SEC         1000UL
 #define PR_USEC_PER_SEC         1000000UL
 #define PR_NSEC_PER_SEC         1000000000UL
 #define PR_USEC_PER_MSEC        1000UL
 #define PR_NSEC_PER_MSEC        1000000UL
 
 /*
  * PRTime --
  *
  *     NSPR represents basic time as 64-bit signed integers relative
  *     to midnight (00:00:00), January 1, 1970 Greenwich Mean Time (GMT).
  *     (GMT is also known as Coordinated Universal Time, UTC.)
  *     The units of time are in microseconds. Negative times are allowed
  *     to represent times prior to the January 1970 epoch. Such values are
  *     intended to be exported to other systems or converted to human
  *     readable form.
  *
  *     Notes on porting: PRTime corresponds to time_t in ANSI C.  NSPR 1.0
  *     simply uses PRInt64.
  */
 
 typedef PRInt64 PRTime;
 
 /*
+ * Long-long (64-bit signed integer type) support macros used by
+ * PR_ImplodeTime().
+ * See http://lxr.mozilla.org/nspr/source/pr/include/prlong.h
+ */
+
+#define LL_I2L(l, i) ((l) = (PRInt64)(i))
+#define LL_MUL(r, a, b) ((r) = (a) * (b))
+#define LL_ADD(r, a, b) ((r) = (a) + (b))
+#define LL_SUB(r, a, b) ((r) = (a) - (b))

[wtc, 2016/02/20 01:05:16]

This is in the middle of the code copied from prtime.h. So I suggest a better
place for the new macros above.

[pkl (ping after 24h if needed), 2016/02/20 07:28:49]

Thank you for the review and suggestion! Code moved. 

+
+/*
  * Time zone and daylight saving time corrections applied to GMT to
  * obtain the local time of some geographic location
  */
 
 typedef struct PRTimeParameters {
     PRInt32 tp_gmt_offset;     /* the offset from GMT in seconds */
     PRInt32 tp_dst_offset;     /* contribution of DST in seconds */
 } PRTimeParameters;
 
 /*
@@ skipping 129 matching lines @@
  * This is the only funtion that should be called from outside base, and only
  * from the unit test.
  */
 
 BASE_EXPORT PRStatus PR_ParseTimeString (
         const char *string,
         PRBool default_to_gmt,
         PRTime *result);
 
 #endif  // BASE_PRTIME_H__