Issue 171313003: Revert 167360 "Revert 167276 "Remove isolatedWorldForEnteredCont..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171313003: Revert 167360 "Revert 167276 "Remove isolatedWorldForEnteredCont..." (Closed)

Created:
6 years, 10 months ago by alecflett

Modified:
6 years, 10 months ago

Reviewers:
alecflett

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 167360 "Revert 167276 "Remove isolatedWorldForEnteredCont..." > Revert 167276 "Remove isolatedWorldForEnteredContext() and isola..." > > > Remove isolatedWorldForEnteredContext() and isolatedWorldForIsolate() > > > > - isolatedWorldForIsolate() is equivalent to DOMWrapperWorld::current()->isIsolatedWorld(). > > > > - isolatedWorldForEnteredContext() is equivalent to DOMWrapperWorld::current()->isIsolatedWorld(). Remember that the world of the current context is equal to the world of the entered context. > > > > Thus this CL replaces these methods with DOMWrapperWorld::current()->isIsolatedWorld(). > > > > BUG=341032 > > R=dcarney@chromium.org, eseidel@chromium.org > > > > Review URL: https://codereview.chromium.org/137953010 > > TBR=haraken@chromium.org > > Review URL: https://codereview.chromium.org/170893003 TBR=alecflett@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167361

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -26 lines)			Patch
M	trunk/Source/bindings/scripts/code_generator_v8.pm	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	trunk/Source/bindings/tests/results/V8TestInterfaceDocument.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	trunk/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/bindings/v8/DOMWrapperWorld.cpp	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	trunk/Source/bindings/v8/ScriptController.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/Source/bindings/v8/V8Binding.h	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	trunk/Source/bindings/v8/custom/V8CustomEventCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/bindings/v8/custom/V8MessageEventCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r167361.