Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 170893003: Revert 167276 "Remove isolatedWorldForEnteredContext() and isola..." (Closed)

Created:
6 years, 10 months ago by alecflett
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews
Visibility:
Public.

Description

Revert 167276 "Remove isolatedWorldForEnteredContext() and isola..." > Remove isolatedWorldForEnteredContext() and isolatedWorldForIsolate() > > - isolatedWorldForIsolate() is equivalent to DOMWrapperWorld::current()->isIsolatedWorld(). > > - isolatedWorldForEnteredContext() is equivalent to DOMWrapperWorld::current()->isIsolatedWorld(). Remember that the world of the current context is equal to the world of the entered context. > > Thus this CL replaces these methods with DOMWrapperWorld::current()->isIsolatedWorld(). > > BUG=341032 > R=dcarney@chromium.org, eseidel@chromium.org > > Review URL: https://codereview.chromium.org/137953010 TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M trunk/Source/bindings/scripts/code_generator_v8.pm View 2 chunks +3 lines, -4 lines 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceDocument.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/DOMWrapperWorld.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M trunk/Source/bindings/v8/ScriptController.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/Source/bindings/v8/V8Binding.h View 2 chunks +10 lines, -0 lines 0 comments Download
M trunk/Source/bindings/v8/custom/V8CustomEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/custom/V8MessageEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alecflett
6 years, 10 months ago (2014-02-18 20:54:55 UTC) #1
alecflett
The CQ bit was checked by alecflett@chromium.org
6 years, 10 months ago (2014-02-18 20:55:48 UTC) #2
alecflett
Even after r267289, we're still seeing crashes on Win7 (dbg): http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/3838/steps/webkit_tests/logs/stdio
6 years, 10 months ago (2014-02-18 20:57:53 UTC) #3
alecflett
6 years, 10 months ago (2014-02-18 21:22:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r167360.

Powered by Google App Engine
This is Rietveld 408576698