Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1712913002: Move m_rgPendingNodes off of CFX_PtrList. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : <list> #

Patch Set 3 : <memory> #

Total comments: 2

Patch Set 4 : Delcaration ordering. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M xfa/src/fxfa/src/parser/xfa_layout_itemlayout.h View 1 2 3 2 chunks +11 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp View 1 2 4 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Lei, for review.
4 years, 10 months ago (2016-02-19 00:15:09 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1712913002/diff/40001/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.h File xfa/src/fxfa/src/parser/xfa_layout_itemlayout.h (right): https://codereview.chromium.org/1712913002/diff/40001/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.h#newcode12 xfa/src/fxfa/src/parser/xfa_layout_itemlayout.h:12: class CXFA_Node; Do you want to touch the ...
4 years, 10 months ago (2016-02-19 00:57:35 UTC) #3
Tom Sepez
https://codereview.chromium.org/1712913002/diff/40001/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.h File xfa/src/fxfa/src/parser/xfa_layout_itemlayout.h (right): https://codereview.chromium.org/1712913002/diff/40001/xfa/src/fxfa/src/parser/xfa_layout_itemlayout.h#newcode12 xfa/src/fxfa/src/parser/xfa_layout_itemlayout.h:12: class CXFA_Node; On 2016/02/19 00:57:34, Lei Zhang wrote: > ...
4 years, 10 months ago (2016-02-19 20:08:33 UTC) #4
Tom Sepez
4 years, 10 months ago (2016-02-19 20:09:16 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
711046ac7043ebeec2b0c9a5eb168418cd07a876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698