Move m_rgPendingNodes off of CFX_PtrList.

xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <algorithm>
+#include <memory>
 
 #include "xfa/src/foxitlib.h"
 #include "xfa/src/fxfa/src/common/xfa_utils.h"
 #include "xfa/src/fxfa/src/common/xfa_object.h"
 #include "xfa/src/fxfa/src/common/xfa_document.h"
 #include "xfa/src/fxfa/src/common/xfa_parser.h"
 #include "xfa/src/fxfa/src/common/xfa_script.h"
 #include "xfa/src/fxfa/src/common/xfa_docdata.h"
 #include "xfa/src/fxfa/src/common/xfa_doclayout.h"
 #include "xfa/src/fxfa/src/common/xfa_localemgr.h"
@@ skipping 1727 matching lines @@
           2;
       break;
   }
   pProcessor->m_pLayoutItem->m_sSize.y += fHeight;
   pProcessor->m_pLayoutItem->AddChild(pLeaderLayoutItem);
 };
 static void XFA_ItemLayoutProcessor_AddPendingNode(
     CXFA_ItemLayoutProcessor* pProcessor,
     CXFA_Node* pPendingNode,
     FX_BOOL bBreakPending) {
-  pProcessor->m_rgPendingNodes.AddTail(pPendingNode);
+  pProcessor->m_PendingNodes.push_back(pPendingNode);
   pProcessor->m_bBreakPending = bBreakPending;
 }
 static FX_FLOAT XFA_ItemLayoutProcessor_InsertPendingItems(
     CXFA_ItemLayoutProcessor* pProcessor,
     CXFA_Node* pCurChildNode) {
   FX_FLOAT fTotalHeight = 0;
-  if (pProcessor->m_rgPendingNodes.GetCount() < 1) {
+  if (pProcessor->m_PendingNodes.empty()) {
     return fTotalHeight;
   }
   if (pProcessor->m_pLayoutItem == NULL) {
     pProcessor->m_pLayoutItem =
         pProcessor->CreateContentLayoutItem(pCurChildNode);
     pProcessor->m_pLayoutItem->m_sSize.Set(0, 0);
   }
-  while (pProcessor->m_rgPendingNodes.GetCount() > 0) {
-    FX_POSITION pos = pProcessor->m_rgPendingNodes.GetHeadPosition();
-    CXFA_Node* pPendingNode =
-        reinterpret_cast<CXFA_Node*>(pProcessor->m_rgPendingNodes.GetAt(pos));
-    pProcessor->m_rgPendingNodes.RemoveAt(pos);
-    CXFA_ContentLayoutItem* pPendingLayoutItem = NULL;
-    CXFA_ItemLayoutProcessor* pPendingProcessor =
-        new CXFA_ItemLayoutProcessor(pPendingNode, NULL);
+  while (!pProcessor->m_PendingNodes.empty()) {
+    std::unique_ptr<CXFA_ItemLayoutProcessor> pPendingProcessor(
+        new CXFA_ItemLayoutProcessor(pProcessor->m_PendingNodes.front(),
+                                     nullptr));
+    pProcessor->m_PendingNodes.pop_front();
 #ifndef _XFA_LAYOUTITEM_ProcessCACHE_
     pPendingProcessor->m_pPageMgrCreateItem = pProcessor->m_pPageMgrCreateItem;
 #endif
     pPendingProcessor->DoLayout(FALSE, XFA_LAYOUT_FLOAT_MAX);
-    pPendingLayoutItem = pPendingProcessor->HasLayoutItem()
-                             ? pPendingProcessor->ExtractLayoutItem()
-                             : NULL;
-    delete pPendingProcessor;
+    CXFA_ContentLayoutItem* pPendingLayoutItem =
+        pPendingProcessor->HasLayoutItem()
+            ? pPendingProcessor->ExtractLayoutItem()
+            : nullptr;
     if (pPendingLayoutItem) {
       XFA_ItemLayoutProcessor_AddLeaderAfterSplit(pProcessor,
                                                   pPendingLayoutItem);
       if (pProcessor->m_bBreakPending) {
         fTotalHeight += pPendingLayoutItem->m_sSize.y;
       }
     }
   }
   return fTotalHeight;
 }
@@ skipping 912 matching lines @@
                               bContainerHeightAutoSize, bContainerWidthAutoSize,
                               fContentCalculatedWidth, fContentCalculatedHeight,
                               fContentCurRowY, fContentCurRowHeight,
                               fContentWidthLimit, bRootForceTb);
     m_fWidthLimite = fContentCurRowAvailWidth;
     if (bForceEndPage) {
       break;
     }
   }
   FX_BOOL bRetValue =
-      (m_nCurChildNodeStage == XFA_ItemLayoutProcessorStages_Done &&
-       m_rgPendingNodes.GetCount() == 0);
+      m_nCurChildNodeStage == XFA_ItemLayoutProcessorStages_Done &&
+      m_PendingNodes.empty();
   if (bBreakDone) {
     bRetValue = FALSE;
   }
   XFA_ItemLayoutProcessor_CalculateContainerComponentSizeFromContentSize(
       m_pFormNode, bContainerWidthAutoSize, fContentCalculatedWidth,
       fContainerWidth, bContainerHeightAutoSize, fContentCalculatedHeight,
       fContainerHeight);
   if (fContainerHeight >= XFA_LAYOUT_FLOAT_PERCISION || m_pLayoutItem ||
       bRetValue) {
     if (m_pLayoutItem == NULL) {
@@ skipping 287 matching lines @@
         (int32_t)(uintptr_t)m_PendingNodesCount.GetValueAt(pTemplate);
     if (iCount >= iMax) {
       return FALSE;
     }
     iCount++;
     m_PendingNodesCount.SetAt(pTemplate, (void*)(uintptr_t)(iCount));
     return TRUE;
   }
   return TRUE;
 }