Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1712713002: Reland of Add check so WIN_FASTLINK will be ignored on VS 2013 (Closed)

Created:
4 years, 10 months ago by brucedawson
Modified:
4 years, 10 months ago
Reviewers:
Fady Samuel, scottmg
CC:
chromium-reviews, Peter Kasting
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add check so WIN_FASTLINK will be ignored on VS 2013 (patchset #1 id:1 of https://codereview.chromium.org/1708073002/ ) Reason for revert: Revert was speculative and ultimately not related to the failure. This CL only affects machines that have fastlink and VS 2015 enabled, which is zero build machines. Original issue's description: > Revert of Add check so WIN_FASTLINK will be ignored on VS 2013 (patchset #4 id:60001 of https://codereview.chromium.org/1707813002/ ) > > Reason for revert: > Speculative revert: https://code.google.com/p/chromium/issues/detail?id=587687 > > Original issue's description: > > Add check so WIN_FASTLINK will be ignored on VS 2013 > > > > win_fastlink is helpful for improving build speeds with VS 2015 but is > > not supported on VS 2013. To make it easier to enable this flag it needs > > to be silently ignored by VS 2013. This makes that happen. > > > > BUG=440500 > > > > Committed: https://crrev.com/6b851bfe96519bca59237b79a003df41dcf98c3b > > Cr-Commit-Position: refs/heads/master@{#375999} > > TBR=scottmg@chromium.org,brucedawson@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=440500 > > Committed: https://crrev.com/063f00be90f3c444179cc512140495ce4a0630fb > Cr-Commit-Position: refs/heads/master@{#376062} TBR=scottmg@chromium.org,fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440500 Committed: https://crrev.com/218d1c4d2c5dc6605c0ebb0b36fe6695f2aa02bd Cr-Commit-Position: refs/heads/master@{#376226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
brucedawson
Created Reland of Add check so WIN_FASTLINK will be ignored on VS 2013
4 years, 10 months ago (2016-02-18 19:07:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712713002/1
4 years, 10 months ago (2016-02-18 19:12:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 19:19:33 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 19:21:22 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/218d1c4d2c5dc6605c0ebb0b36fe6695f2aa02bd
Cr-Commit-Position: refs/heads/master@{#376226}

Powered by Google App Engine
This is Rietveld 408576698