Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1712713002: Reland of Add check so WIN_FASTLINK will be ignored on VS 2013 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/ccache.gni") 9 import("//build/toolchain/ccache.gni")
10 10
(...skipping 1248 matching lines...) Expand 10 before | Expand all | Expand 10 after
1259 1259
1260 # Full symbols. 1260 # Full symbols.
1261 config("symbols") { 1261 config("symbols") {
1262 if (is_win) { 1262 if (is_win) {
1263 import("//build/toolchain/goma.gni") 1263 import("//build/toolchain/goma.gni")
1264 if (use_goma) { 1264 if (use_goma) {
1265 cflags = [ "/Z7" ] # No PDB file 1265 cflags = [ "/Z7" ] # No PDB file
1266 } else { 1266 } else {
1267 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue. 1267 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
1268 } 1268 }
1269 if (is_win_fastlink) { 1269 if (is_win_fastlink && visual_studio_version != "2013") {
1270 # Tell VS 2015+ to create a PDB that references debug 1270 # Tell VS 2015+ to create a PDB that references debug
1271 # information in .obj and .lib files instead of copying 1271 # information in .obj and .lib files instead of copying
1272 # it all. This flag is incompatible with /PROFILE 1272 # it all. This flag is incompatible with /PROFILE
1273 ldflags = [ "/DEBUG:FASTLINK" ] 1273 ldflags = [ "/DEBUG:FASTLINK" ]
1274 } else { 1274 } else {
1275 ldflags = [ "/DEBUG" ] 1275 ldflags = [ "/DEBUG" ]
1276 } 1276 }
1277 } else { 1277 } else {
1278 cflags = [ "-g2" ] 1278 cflags = [ "-g2" ]
1279 if (use_debug_fission) { 1279 if (use_debug_fission) {
1280 cflags += [ "-gsplit-dwarf" ] 1280 cflags += [ "-gsplit-dwarf" ]
1281 } 1281 }
1282 asmflags = cflags 1282 asmflags = cflags
1283 ldflags = [] 1283 ldflags = []
1284 } 1284 }
1285 } 1285 }
1286 1286
1287 # Minimal symbols. 1287 # Minimal symbols.
1288 config("minimal_symbols") { 1288 config("minimal_symbols") {
1289 if (is_win) { 1289 if (is_win) {
1290 # Linker symbols for backtraces only. 1290 # Linker symbols for backtraces only.
1291 cflags = [] 1291 cflags = []
1292 if (is_win_fastlink) { 1292 if (is_win_fastlink && visual_studio_version != "2013") {
1293 # Tell VS 2015+ to create a PDB that references debug 1293 # Tell VS 2015+ to create a PDB that references debug
1294 # information in .obj and .lib files instead of copying 1294 # information in .obj and .lib files instead of copying
1295 # it all. This flag is incompatible with /PROFILE 1295 # it all. This flag is incompatible with /PROFILE
1296 ldflags = [ "/DEBUG:FASTLINK" ] 1296 ldflags = [ "/DEBUG:FASTLINK" ]
1297 } else { 1297 } else {
1298 ldflags = [ "/DEBUG" ] 1298 ldflags = [ "/DEBUG" ]
1299 } 1299 }
1300 } else { 1300 } else {
1301 cflags = [ "-g1" ] 1301 cflags = [ "-g1" ]
1302 if (use_debug_fission) { 1302 if (use_debug_fission) {
(...skipping 17 matching lines...) Expand all
1320 if (symbol_level == 0) { 1320 if (symbol_level == 0) {
1321 configs = [ ":no_symbols" ] 1321 configs = [ ":no_symbols" ]
1322 } else if (symbol_level == 1) { 1322 } else if (symbol_level == 1) {
1323 configs = [ ":minimal_symbols" ] 1323 configs = [ ":minimal_symbols" ]
1324 } else if (symbol_level == 2) { 1324 } else if (symbol_level == 2) {
1325 configs = [ ":symbols" ] 1325 configs = [ ":symbols" ]
1326 } else { 1326 } else {
1327 assert(false) 1327 assert(false)
1328 } 1328 }
1329 } 1329 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698