Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1712693002: Revert "Remove yasm (and DONT_EMBED_BUILD_METADATA)." (Closed)

Created:
4 years, 10 months ago by viettrungluu
Modified:
4 years, 10 months ago
Reviewers:
dalesat, jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Revert "Remove yasm (and DONT_EMBED_BUILD_METADATA)." This reverts commit 49afea12c414df95e4a12974b443812293842cce. Apparently we (will) need it for ffmpeg. I'm going to land this revert, and then try to update our yasm to the same one that Chromium currently has so that we can still get rid of DONT_EMBED_BUILD_METADATA. TBR=dalesat@chromium.org, jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f97ec84cbf981320bff0c6fba44231fde3e592ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24958 lines, -0 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/BUILD.gn View 2 chunks +14 lines, -0 lines 0 comments Download
A third_party/yasm/BUILD.gn View 1 chunk +472 lines, -0 lines 0 comments Download
A third_party/yasm/CHROMIUM.diff View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/yasm/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/yasm/README.chromium View 1 chunk +142 lines, -0 lines 0 comments Download
A third_party/yasm/run_yasm.py View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/android/Makefile View 1 chunk +3822 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/android/config.h View 1 chunk +173 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/android/libyasm-stdint.h View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/ios/Makefile View 1 chunk +3822 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/ios/config.h View 1 chunk +173 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/ios/libyasm-stdint.h View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/linux/Makefile View 1 chunk +3822 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/linux/config.h View 1 chunk +173 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/linux/libyasm-stdint.h View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/mac/Makefile View 1 chunk +3822 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/mac/config.h View 1 chunk +173 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/mac/libyasm-stdint.h View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/openbsd/Makefile View 1 chunk +3822 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/openbsd/config.h View 1 chunk +165 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/openbsd/libyasm-stdint.h View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/win/Makefile View 1 chunk +3822 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/win/config.h View 1 chunk +173 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/win/libyasm-stdint.h View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/yasm/source/config/win/stdint.h View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/yasm/yasm_assemble.gni View 1 chunk +203 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
viettrungluu
4 years, 10 months ago (2016-02-18 18:32:52 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f97ec84cbf981320bff0c6fba44231fde3e592ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698