Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: build/config/BUILD.gn

Issue 1712693002: Revert "Remove yasm (and DONT_EMBED_BUILD_METADATA)." (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « DEPS ('k') | third_party/yasm/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//build/module_args/v8.gni") 9 import("//build/module_args/v8.gni")
10 10
11 declare_args() { 11 declare_args() {
12 # When set, turns off the (normally-on) iterator debugging and related stuff 12 # When set, turns off the (normally-on) iterator debugging and related stuff
13 # that is normally turned on for Debug builds. These are generally useful for 13 # that is normally turned on for Debug builds. These are generally useful for
14 # catching bugs but in some cases may cause conflicts or excessive slowness. 14 # catching bugs but in some cases may cause conflicts or excessive slowness.
15 disable_iterator_debugging = false 15 disable_iterator_debugging = false
16 16
17 # Set to true to not store any build metadata, e.g. ifdef out all __DATE__
18 # and __TIME__. Set to 0 to reenable the use of these macros in the code
19 # base. See http://crbug.com/314403.
20 #
21 # Continue to embed build meta data in Official builds, basically the
22 # time it was built.
23 # TODO(maruel): This decision should be revisited because having an
24 # official deterministic build has high value too but MSVC toolset can't
25 # generate anything deterministic with WPO enabled AFAIK.
26 dont_embed_build_metadata = !is_official_build
27
17 # Set to true to enable dcheck in Release builds. 28 # Set to true to enable dcheck in Release builds.
18 dcheck_always_on = false 29 dcheck_always_on = false
19 30
20 # Set to true to compile with the OpenGL ES 2.0 conformance tests. 31 # Set to true to compile with the OpenGL ES 2.0 conformance tests.
21 internal_gles2_conform_tests = false 32 internal_gles2_conform_tests = false
22 } 33 }
23 34
24 # TODO(brettw) Most of these should be removed. Instead of global feature 35 # TODO(brettw) Most of these should be removed. Instead of global feature
25 # flags, we should have more modular flags that apply only to a target and its 36 # flags, we should have more modular flags that apply only to a target and its
26 # dependents. For example, depending on the "x11" meta-target should define 37 # dependents. For example, depending on the "x11" meta-target should define
27 # USE_X11 for all dependents so that everything that could use X11 gets the 38 # USE_X11 for all dependents so that everything that could use X11 gets the
28 # define, but anything that doesn't depend on X11 doesn't see it. 39 # define, but anything that doesn't depend on X11 doesn't see it.
29 # 40 #
30 # For now we define these globally to match the current GYP build. 41 # For now we define these globally to match the current GYP build.
31 config("feature_flags") { 42 config("feature_flags") {
32 # TODO(brettw) this probably needs to be parameterized. 43 # TODO(brettw) this probably needs to be parameterized.
33 defines = [ "V8_DEPRECATION_WARNINGS" ] # Don't use deprecated V8 APIs anywhe re. 44 defines = [ "V8_DEPRECATION_WARNINGS" ] # Don't use deprecated V8 APIs anywhe re.
34 45
46 if (dont_embed_build_metadata) {
47 defines += [ "DONT_EMBED_BUILD_METADATA" ]
48 }
35 if (dcheck_always_on) { 49 if (dcheck_always_on) {
36 defines += [ "DCHECK_ALWAYS_ON=1" ] 50 defines += [ "DCHECK_ALWAYS_ON=1" ]
37 } 51 }
38 if (use_udev) { 52 if (use_udev) {
39 # TODO(brettw) should probably be "=1". 53 # TODO(brettw) should probably be "=1".
40 defines += [ "USE_UDEV" ] 54 defines += [ "USE_UDEV" ]
41 } 55 }
42 if (use_ozone) { 56 if (use_ozone) {
43 defines += [ "USE_OZONE=1" ] 57 defines += [ "USE_OZONE=1" ]
44 } 58 }
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 "CoreFoundation.framework", 170 "CoreFoundation.framework",
157 "CoreGraphics.framework", 171 "CoreGraphics.framework",
158 "CoreText.framework", 172 "CoreText.framework",
159 "Foundation.framework", 173 "Foundation.framework",
160 "UIKit.framework", 174 "UIKit.framework",
161 ] 175 ]
162 } else if (is_linux) { 176 } else if (is_linux) {
163 libs = [ "dl" ] 177 libs = [ "dl" ]
164 } 178 }
165 } 179 }
OLDNEW
« no previous file with comments | « DEPS ('k') | third_party/yasm/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698