Navigations from WebUSB notifications are not renderer initiated

Navigations from WebUSB notifications are not renderer initiated

The |is_renderer_initiated| flag in the OpenURLParams
should be set to false as the navigation initiated when
the user clicks on a WebUSB notification is initiated by
the browser and not the renderer.

BUG=492204
Committed: https://crrev.com/e4a7d78df22965e54b3f0e3609152e73eae327e5
Cr-Commit-Position: refs/heads/master@{#376250}

[juncai, 2016-02-18 18:18:22]

juncai@chromium.org changed reviewers:
+ reillyg@chromium.org

[juncai, 2016-02-18 18:18:22]

Please review this patch.

[Reilly Grant (use Gerrit), 2016-02-18 18:36:45]

lgtm but the description could be clearer as I had to look up the meaning of
is_renderer_initialized to understand the purpose of the patch. Ideally there
would be a bug describing the broken behavior that the incorrect parameter
caused but just providing that in the description is also ok. I suggest
something like:

Navigations from WebUSB notifications are not renderer initiated

The |is_renderer_initiated| flag in the OpenURLParams should be set
to false as the navigation initiated when the user clicks on a WebUSB
notification is initiated by the browser and not the renderer.

Setting this flag to true caused <insert incorrect behavior here>.

https://codereview.chromium.org/1712683002/diff/1/chrome/browser/chrome_webus...
File chrome/browser/chrome_webusb_browser_client.cc (right):

https://codereview.chromium.org/1712683002/diff/1/chrome/browser/chrome_webus...
chrome/browser/chrome_webusb_browser_client.cc:65:
ui::PAGE_TRANSITION_AUTO_TOPLEVEL, /*is_renderer_initiated=*/false));
nit: The usual way to annotate this is:

false /* is_renderer_initialized */

[juncai, 2016-02-18 18:59:07]

Description was changed from

==========
Modified is_renderer_initiated parameter when opening url
for webusb notification

This patch changed the is_renderer_initiated parameter to be false when
opening url for webusb notification, since this is handled by browser
process.

BUG=492204
==========

to

==========
Navigations from WebUSB notifications are not renderer initiated

The |is_renderer_initiated| flag in the OpenURLParams 
should be set to false as the navigation initiated when
the user clicks on a WebUSB notification is initiated by 
the browser and not the renderer.

BUG=492204
==========

[juncai, 2016-02-18 20:17:51]

https://codereview.chromium.org/1712683002/diff/1/chrome/browser/chrome_webus...
File chrome/browser/chrome_webusb_browser_client.cc (right):

https://codereview.chromium.org/1712683002/diff/1/chrome/browser/chrome_webus...
chrome/browser/chrome_webusb_browser_client.cc:65:
ui::PAGE_TRANSITION_AUTO_TOPLEVEL, /*is_renderer_initiated=*/false));
On 2016/02/18 18:36:45, Reilly Grant wrote:
> nit: The usual way to annotate this is:
> 
> false /* is_renderer_initialized */

Done.

[juncai, 2016-02-18 20:18:00]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-02-18 20:18:00]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/1712683002/#ps20001
(title: "address reillyg@'s comments")

[commit-bot: I haz the power, 2016-02-18 20:20:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1712683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1712683002/20001

[commit-bot: I haz the power, 2016-02-18 20:42:52]

Description was changed from

==========
Navigations from WebUSB notifications are not renderer initiated

The |is_renderer_initiated| flag in the OpenURLParams 
should be set to false as the navigation initiated when
the user clicks on a WebUSB notification is initiated by 
the browser and not the renderer.

BUG=492204
==========

to

==========
Navigations from WebUSB notifications are not renderer initiated

The |is_renderer_initiated| flag in the OpenURLParams 
should be set to false as the navigation initiated when
the user clicks on a WebUSB notification is initiated by 
the browser and not the renderer.

BUG=492204
==========

[commit-bot: I haz the power, 2016-02-18 20:42:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-18 20:45:05]

Description was changed from

==========
Navigations from WebUSB notifications are not renderer initiated

The |is_renderer_initiated| flag in the OpenURLParams 
should be set to false as the navigation initiated when
the user clicks on a WebUSB notification is initiated by 
the browser and not the renderer.

BUG=492204
==========

to

==========
Navigations from WebUSB notifications are not renderer initiated

The |is_renderer_initiated| flag in the OpenURLParams
should be set to false as the navigation initiated when
the user clicks on a WebUSB notification is initiated by
the browser and not the renderer.

BUG=492204

Committed: https://crrev.com/e4a7d78df22965e54b3f0e3609152e73eae327e5
Cr-Commit-Position: refs/heads/master@{#376250}
==========

[commit-bot: I haz the power, 2016-02-18 20:45:06]

Patchset 2 (id:??) landed as
https://crrev.com/e4a7d78df22965e54b3f0e3609152e73eae327e5
Cr-Commit-Position: refs/heads/master@{#376250}