chrome/browser/chrome_webusb_browser_client.cc - Issue 1712683002: Navigations from WebUSB notifications are not renderer initiated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_webusb_browser_client.cc

Issue 1712683002: Navigations from WebUSB notifications are not renderer initiated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address reillyg@'s comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_webusb_browser_client.cc

diff --git a/chrome/browser/chrome_webusb_browser_client.cc b/chrome/browser/chrome_webusb_browser_client.cc

index 269cf154e569d63ab60a3ad885e7829633657877..a2a1e0650a84d2737b0637d56feba78f9093892e 100644

--- a/chrome/browser/chrome_webusb_browser_client.cc

+++ b/chrome/browser/chrome_webusb_browser_client.cc

@@ -60,9 +60,9 @@ Browser* GetBrowser() {

}

void OpenURL(const GURL& url) {

- GetBrowser()->OpenURL(

- content::OpenURLParams(url, content::Referrer(), NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_AUTO_TOPLEVEL, true));

+ GetBrowser()->OpenURL(content::OpenURLParams(

+ url, content::Referrer(), NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false /* is_renderer_initialized */));

}

// Delegate for webusb notification

« no previous file with comments | « no previous file | no next file » | no next file with comments »