Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1712563002: [turbofan] Move lowering of ObjectIs* nodes to ChangeLowering. (Closed)

Created:
4 years, 10 months ago by Jarin
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move lowering of ObjectIs* nodes to ChangeLowering. Committed: https://crrev.com/a56af88942f1b52fb6c31967aeeb63411d13fbc2 Cr-Commit-Position: refs/heads/master@{#34137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -83 lines) Patch
M src/compiler/change-lowering.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/change-lowering.cc View 2 chunks +76 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +0 lines, -77 lines 0 comments Download

Dependent Patchsets:

Issue 1709093002 Patch 1

Messages

Total messages: 8 (3 generated)
Jarin
Could you take look, please? (Just moving stuff around before the scheduler split.)
4 years, 10 months ago (2016-02-18 14:41:39 UTC) #2
Benedikt Meurer
LGTM
4 years, 10 months ago (2016-02-18 17:51:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712563002/1
4 years, 10 months ago (2016-02-19 07:17:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 07:18:49 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 07:19:16 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a56af88942f1b52fb6c31967aeeb63411d13fbc2
Cr-Commit-Position: refs/heads/master@{#34137}

Powered by Google App Engine
This is Rietveld 408576698