Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1709093002: [turbofan] Connect ObjectIsNumber to effect and control chains. (Closed)

Created:
4 years, 10 months ago by Jarin
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@move-change-low
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Connect ObjectIsNumber to effect and control chains. In theory, we could connect the nodes when doing the schedule-in-the-middle pass, but that would require creating two versions of the operator (effectful and pure). I believe we do not lose anything by wiring the node up eagerly. Committed: https://crrev.com/2894e80a0a4a51a0d72e72aa48fcd01968f7949f Cr-Commit-Position: refs/heads/master@{#34141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -38 lines) Patch
M src/compiler/change-lowering.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/change-lowering.cc View 2 chunks +23 lines, -15 lines 0 comments Download
M src/compiler/graph-reducer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 4 chunks +16 lines, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Jarin
Could you take a look, please?
4 years, 10 months ago (2016-02-18 16:31:53 UTC) #2
Benedikt Meurer
LGTM.
4 years, 10 months ago (2016-02-19 07:54:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709093002/1
4 years, 10 months ago (2016-02-19 08:01:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 08:03:11 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2894e80a0a4a51a0d72e72aa48fcd01968f7949f Cr-Commit-Position: refs/heads/master@{#34141}
4 years, 10 months ago (2016-02-19 08:03:43 UTC) #8
Jarin
4 years, 10 months ago (2016-02-19 10:13:20 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1718483002/ by jarin@chromium.org.

The reason for reverting is: Tanks benchmarks (e.g., Octane box2d TF)..

Powered by Google App Engine
This is Rietveld 408576698