third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp - Issue 1712503002: [css-grid] Rows track sizes are optional in grid-template shorthand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1712503002: [css-grid] Rows track sizes are optional in grid-template shorthand (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html ('K') | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

index 04699821fd86048d37303e5eaafed4ebdaafd0fe..20f512a066f73ac4571a27d96395f692bcc2a9ec 100644

--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

@@ -1521,7 +1521,7 @@ bool CSSPropertyParser::parseGridTemplateRowsAndAreas(PassRefPtrWillBeRawPtr<CSS

++rowCount;

// Handle template-rows's track-size.

- if (m_valueList->current() && m_valueList->current()->m_unit != CSSParserValue::String) {

+ if (m_valueList->current() && m_valueList->current()->m_unit != CSSParserValue::String && m_valueList->current()->m_unit != CSSParserValue::Operator) {

RefPtrWillBeRawPtr<CSSValue> value = parseGridTrackSize(*m_valueList);

if (!value)

return false;

@@ -1596,7 +1596,7 @@ bool CSSPropertyParser::parseGridTemplateShorthand(bool important)

}

- // 3- [<track-list> /]? [<line-names>? <string> [<track-size> <line-names>]? ]+ syntax.

+ // 3- [<track-list> /]? [<line-names>? <string> <track-size>? <line-names>? ]+ syntax.

// The template-columns <track-list> can't be 'none'.

if (firstValueIsNone)

return false;