[css-grid] Rows track sizes are optional in grid-template shorthand

[css-grid] Rows track sizes are optional in grid-template shorthand

You can omit the size of the rows in grid-template shorthand,
even if you specify a named grid line for the end of the row,
due to a change in the spec back in 2014:
https://github.com/w3c/csswg-drafts/commit/9f660c4183c73c1f5279c46904dc6cb314f76194

Before if you want to specify a named grid line,
you need to set the row size.

Update parsing, so it nows accepts things like:
    grid-template: 100px / "a" [bottom];

BUG=528609
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html

Committed: https://crrev.com/6b4231e6900ab5eeb42cf4c2da6e02f118705207
Cr-Commit-Position: refs/heads/master@{#376706}

[Manuel Rego, 2016-02-18 11:17:27]

rego@igalia.com changed reviewers:
+ rune@opera.com, svillar@igalia.com, timloh@chromium.org

[svillar, 2016-02-19 11:18:01]

Waiting for the rebased patch...

https://codereview.chromium.org/1712503002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html
(right):

https://codereview.chromium.org/1712503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html:29:
}
As you're adding also a test case with multiple names, perhaps it'd be more
interesting to add also the case of

[head] "a" [tail] 10px

for example

[svillar, 2016-02-19 11:48:44]

lgtm

https://codereview.chromium.org/1712503002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
(right):

https://codereview.chromium.org/1712503002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp:1483: if
(m_valueList->current() && !isForwardSlashOperator(m_valueList->current()) &&
m_valueList->current()->m_unit != CSSParserValue::String &&
m_valueList->current()->m_unit != CSSParserValue::Operator) {
As you told me in private, != Operator includes !isForwardSlashOperator

[Manuel Rego, 2016-02-19 12:24:37]

Thanks for the review!
Uploaded new patch with suggested changes.

Now I need an OWNER for css/
@timloh or @rune could you please take a look?
Thanks :-)

https://codereview.chromium.org/1712503002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html
(right):

https://codereview.chromium.org/1712503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html:29:
}
On 2016/02/19 11:18:00, svillar wrote:
> [head] "a" [tail] 10px
> 
> for example

Yes, but for the bad values, as that would be invalid.

I've added some examples like that.

https://codereview.chromium.org/1712503002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
(right):

https://codereview.chromium.org/1712503002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp:1483: if
(m_valueList->current() && !isForwardSlashOperator(m_valueList->current()) &&
m_valueList->current()->m_unit != CSSParserValue::String &&
m_valueList->current()->m_unit != CSSParserValue::Operator) {
On 2016/02/19 11:48:44, svillar wrote:
> As you told me in private, != Operator includes !isForwardSlashOperator

Done.

[Timothy Loh, 2016-02-21 23:53:53]

lgtm

[Manuel Rego, 2016-02-22 08:07:03]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2016-02-22 08:07:03]

The patchset sent to the CQ was uploaded after l-g-t-m from svillar@igalia.com
Link to the patchset: https://codereview.chromium.org/1712503002/#ps40001
(title: "Applied suggested changes")

[commit-bot: I haz the power, 2016-02-22 08:07:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1712503002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1712503002/40001

[commit-bot: I haz the power, 2016-02-22 09:16:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-22 09:17:51]

Description was changed from

==========
[css-grid] Rows track sizes are optional in grid-template shorthand

You can omit the size of the rows in grid-template shorthand,
even if you specify a named grid line for the end of the row,
due to a change in the spec back in 2014:
https://github.com/w3c/csswg-drafts/commit/9f660c4183c73c1f5279c46904dc6cb314...

Before if you want to specify a named grid line,
you need to set the row size.

Update parsing, so it nows accepts things like:
    grid-template: 100px / "a" [bottom];

BUG=528609
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html
==========

to

==========
[css-grid] Rows track sizes are optional in grid-template shorthand

You can omit the size of the rows in grid-template shorthand,
even if you specify a named grid line for the end of the row,
due to a change in the spec back in 2014:
https://github.com/w3c/csswg-drafts/commit/9f660c4183c73c1f5279c46904dc6cb314...

Before if you want to specify a named grid line,
you need to set the row size.

Update parsing, so it nows accepts things like:
    grid-template: 100px / "a" [bottom];

BUG=528609
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html

Committed: https://crrev.com/6b4231e6900ab5eeb42cf4c2da6e02f118705207
Cr-Commit-Position: refs/heads/master@{#376706}
==========

[commit-bot: I haz the power, 2016-02-22 09:17:51]

Patchset 3 (id:??) landed as
https://crrev.com/6b4231e6900ab5eeb42cf4c2da6e02f118705207
Cr-Commit-Position: refs/heads/master@{#376706}