core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp - Issue 1712353002: Remove IFX_BufferArchive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

Issue 1712353002: Remove IFX_BufferArchive. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebased. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

index 7d294c4c52bcdf4b724e581027d3168d0a6e937d..328dc5330fac34fabf4cadeae92bdd85990eaaac 100644

--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

@@ -1948,9 +1948,7 @@ FX_BOOL CPDF_Creator::Create(IFX_StreamWrite* pFile, FX_DWORD flags) {

if (!pFile) {

Lei Zhang 2016/02/19 23:09:57 AFAICT, there's only 1 caller and |pFile| is alway

Tom Sepez 2016/02/19 23:24:26 Done.

return FALSE;

}

- if (!m_File.AttachFile(pFile, FALSE)) {

- return FALSE;

- }

+ m_File.AttachFile(pFile);

return Create(flags);

}

FX_BOOL CPDF_Creator::Create(FX_DWORD flags) {

« no previous file with comments | « core/include/fxcrt/fx_basic.h ('k') | core/src/fxcrt/fx_basic_buffer.cpp » ('j') | no next file with comments »