Remove IFX_BufferArchive.

core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/src/fpdfapi/fpdf_edit/editint.h"
 
 #include <vector>
 
@@ skipping 1927 matching lines @@
   delete m_pXRefStream;
   m_pXRefStream = NULL;
   m_File.Clear();
   m_NewObjNumArray.RemoveAll();
   if (m_pIDArray) {
     m_pIDArray->Release();
     m_pIDArray = NULL;
   }
 }
 FX_BOOL CPDF_Creator::Create(IFX_StreamWrite* pFile, FX_DWORD flags) {
   if (!pFile) {

[Lei Zhang, 2016/02/19 23:09:57]

AFAICT, there's only 1 caller and |pFile| is always non-null.

[Tom Sepez, 2016/02/19 23:24:26]

Done.

     return FALSE;
   }
-  if (!m_File.AttachFile(pFile, FALSE)) {
-    return FALSE;
-  }
+  m_File.AttachFile(pFile);
   return Create(flags);
 }
 FX_BOOL CPDF_Creator::Create(FX_DWORD flags) {
   m_dwFlags = flags;
   m_iStage = 0;
   m_Offset = 0;
   m_dwLastObjNum = m_pDocument->GetLastObjNum();
   m_ObjectOffset.Clear();
   m_NewObjNumArray.RemoveAll();
   InitID();
@@ skipping 97 matching lines @@
   m_bNewCrypto = FALSE;
   if (!m_bStandardSecurity) {
     return;
   }
   if (m_pEncryptDict) {
     m_pEncryptDict->Release();
     m_pEncryptDict = NULL;
   }
   m_bStandardSecurity = FALSE;
 }