Remove IFX_BufferArchive.

Remove IFX_BufferArchive.

Merge it into CFX_FileBufferArchive, since both are in the
same header file and it is the only subclass.

Also, bTakeOver is always false, and the buf size is always
32K.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/ac121aa23a5ee3290af151dddbbdc0f4644098d4

[Tom Sepez, 2016-02-19 21:18:19]

Description was changed from

==========
Remove IFX_BufferArchive.

Merge it into CFX_FileBufferArchive, since both are in the
same header file and its the only subclass.
==========

to

==========
Remove IFX_BufferArchive.

Merge it into CFX_FileBufferArchive, since both are in the
same header file and its the only subclass.

Also, bTakeOver is always false.
==========

[Tom Sepez, 2016-02-19 21:18:38]

Description was changed from

==========
Remove IFX_BufferArchive.

Merge it into CFX_FileBufferArchive, since both are in the
same header file and its the only subclass.

Also, bTakeOver is always false.
==========

to

==========
Remove IFX_BufferArchive.

Merge it into CFX_FileBufferArchive, since both are in the
same header file and it is the only subclass.

Also, bTakeOver is always false.
==========

[Tom Sepez, 2016-02-19 22:48:28]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-19 22:48:29]

Lei, pls. review.

[Tom Sepez, 2016-02-19 22:49:54]

Description was changed from

==========
Remove IFX_BufferArchive.

Merge it into CFX_FileBufferArchive, since both are in the
same header file and it is the only subclass.

Also, bTakeOver is always false.
==========

to

==========
Remove IFX_BufferArchive.

Merge it into CFX_FileBufferArchive, since both are in the
same header file and it is the only subclass.

Also, bTakeOver is always false, and the buf size is always
32K.
==========

[Lei Zhang, 2016-02-19 23:09:57]

lgtm

https://codereview.chromium.org/1712353002/diff/120001/core/src/fpdfapi/fpdf_...
File core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):

https://codereview.chromium.org/1712353002/diff/120001/core/src/fpdfapi/fpdf_...
core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:1948: if (!pFile) {
AFAICT, there's only 1 caller and |pFile| is always non-null.

[Tom Sepez, 2016-02-19 23:24:26]

https://codereview.chromium.org/1712353002/diff/120001/core/src/fpdfapi/fpdf_...
File core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):

https://codereview.chromium.org/1712353002/diff/120001/core/src/fpdfapi/fpdf_...
core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:1948: if (!pFile) {
On 2016/02/19 23:09:57, Lei Zhang wrote:
> AFAICT, there's only 1 caller and |pFile| is always non-null.

Done.

[Tom Sepez, 2016-02-19 23:25:04]

Description was changed from

==========
Remove IFX_BufferArchive.

Merge it into CFX_FileBufferArchive, since both are in the
same header file and it is the only subclass.

Also, bTakeOver is always false, and the buf size is always
32K.
==========

to

==========
Remove IFX_BufferArchive.

Merge it into CFX_FileBufferArchive, since both are in the
same header file and it is the only subclass.

Also, bTakeOver is always false, and the buf size is always
32K.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/ac121aa23a5ee3290af151dddbbdc0f46440...
==========

[Tom Sepez, 2016-02-19 23:25:05]

Committed patchset #8 (id:140001) manually as
ac121aa23a5ee3290af151dddbbdc0f4644098d4 (presubmit successful).