Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1712163002: [builtins] Migrate the DataView constructor to C++. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate the DataView constructor to C++. The DataView constructor calls into C++ anyway, and is easier to deal with this way, especially since we don't have the half initialized object floating through JavaScript. R=yangguo@chromium.org Committed: https://crrev.com/be23438170156e13030ea0d4837a5785098faeff Cr-Commit-Position: refs/heads/master@{#34145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -102 lines) Patch
M src/bootstrapper.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/builtins.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +112 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/js/typedarray.js View 2 chunks +0 lines, -31 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M test/mjsunit/es6/typedarray.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-19 08:36:31 UTC) #1
Benedikt Meurer
Hey Yang, Idea is to get rid of the JSBuiltinConstructStub, which requires special handling currently, ...
4 years, 10 months ago (2016-02-19 08:37:22 UTC) #2
Yang
On 2016/02/19 08:37:22, Benedikt Meurer wrote: > Hey Yang, > > Idea is to get ...
4 years, 10 months ago (2016-02-19 08:44:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712163002/1
4 years, 10 months ago (2016-02-19 08:46:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 08:58:37 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 08:59:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be23438170156e13030ea0d4837a5785098faeff
Cr-Commit-Position: refs/heads/master@{#34145}

Powered by Google App Engine
This is Rietveld 408576698