Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: src/crankshaft/hydrogen.cc

Issue 1712163002: [builtins] Migrate the DataView constructor to C++. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen.h ('k') | src/js/typedarray.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.cc
diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc
index a91e11cf5d2ac19d4232416ccfb8ba7c9bce2850..c3fa873c640a565f155da37132da35667fc049f3 100644
--- a/src/crankshaft/hydrogen.cc
+++ b/src/crankshaft/hydrogen.cc
@@ -10200,31 +10200,6 @@ void HGraphBuilder::BuildArrayBufferViewInitialization(
}
-void HOptimizedGraphBuilder::GenerateDataViewInitialize(
- CallRuntime* expr) {
- ZoneList<Expression*>* arguments = expr->arguments();
-
- DCHECK(arguments->length()== 4);
- CHECK_ALIVE(VisitForValue(arguments->at(0)));
- HValue* obj = Pop();
-
- CHECK_ALIVE(VisitForValue(arguments->at(1)));
- HValue* buffer = Pop();
-
- CHECK_ALIVE(VisitForValue(arguments->at(2)));
- HValue* byte_offset = Pop();
-
- CHECK_ALIVE(VisitForValue(arguments->at(3)));
- HValue* byte_length = Pop();
-
- {
- NoObservableSideEffectsScope scope(this);
- BuildArrayBufferViewInitialization<JSDataView>(
- obj, buffer, byte_offset, byte_length);
- }
-}
-
-
HValue* HOptimizedGraphBuilder::BuildAllocateExternalElements(
ExternalArrayType array_type,
bool is_zero_byte_offset,
« no previous file with comments | « src/crankshaft/hydrogen.h ('k') | src/js/typedarray.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698