Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1711863003: Disable --harmony-object-observe (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich, pfeldman
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable --harmony-object-observe This was previously reverted due to breakage in devtools, but that has been worked around in https://codereview.chromium.org/1666573002. The feature has been publicly-announced as deprecated for several months, and Chrome 49 will emit deprecation warnings in the console for uses of the API. This CL aims to remove it from M50 (which is what the message warns of). BUG=chromium:552100 LOG=y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/9f42c69396d326d9188b54814899397c47575e21 Cr-Commit-Position: refs/heads/master@{#34171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
adamk
4 years, 10 months ago (2016-02-18 19:02:40 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711863003/1
4 years, 10 months ago (2016-02-18 19:03:46 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 20:10:03 UTC) #7
rossberg
lgtm
4 years, 10 months ago (2016-02-19 12:12:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711863003/1
4 years, 10 months ago (2016-02-19 20:16:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 21:24:59 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 21:25:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f42c69396d326d9188b54814899397c47575e21
Cr-Commit-Position: refs/heads/master@{#34171}

Powered by Google App Engine
This is Rietveld 408576698