Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1666573002: [DevTools] Polyfill Object.observe for old frontends. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Polyfill Object.observe for old frontends. BUG=583148 Committed: https://crrev.com/ba252595f1a4fe15681e1602e24f3268c8a3aa46 Cr-Commit-Position: refs/heads/master@{#373414}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/common/Settings.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devtools.js View 1 2 chunks +102 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dgozman
Take a look please.
4 years, 10 months ago (2016-02-03 02:46:44 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1666573002/diff/1/third_party/WebKit/Source/devtools/front_end/devtools.js File third_party/WebKit/Source/devtools/front_end/devtools.js (right): https://codereview.chromium.org/1666573002/diff/1/third_party/WebKit/Source/devtools/front_end/devtools.js#newcode978 third_party/WebKit/Source/devtools/front_end/devtools.js:978: if (typeof window.Object.observe !== "function") Lets define it ...
4 years, 10 months ago (2016-02-03 03:11:52 UTC) #3
dgozman
https://codereview.chromium.org/1666573002/diff/1/third_party/WebKit/Source/devtools/front_end/devtools.js File third_party/WebKit/Source/devtools/front_end/devtools.js (right): https://codereview.chromium.org/1666573002/diff/1/third_party/WebKit/Source/devtools/front_end/devtools.js#newcode978 third_party/WebKit/Source/devtools/front_end/devtools.js:978: if (typeof window.Object.observe !== "function") On 2016/02/03 03:11:52, pfeldman ...
4 years, 10 months ago (2016-02-03 23:47:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666573002/20001
4 years, 10 months ago (2016-02-03 23:49:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-04 01:26:44 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 01:28:30 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ba252595f1a4fe15681e1602e24f3268c8a3aa46
Cr-Commit-Position: refs/heads/master@{#373414}

Powered by Google App Engine
This is Rietveld 408576698