Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1711863002: [es6] Fixed POSSIBLY_EVAL_CALL tail calls handling in Full codegen. (Closed)

Created:
4 years, 10 months ago by Igor Sheludko
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fixed POSSIBLY_EVAL_CALL tail calls handling in Full codegen. This CL also enhances a "tail-call-megatest" which now tests product of the following cases: 1) tail caller is inlined/not-inlined 2) tail callee is inlined/not-inlined 3) tail caller has an arguments adaptor frame above or not 4) tail callee has an arguments adaptor frame above or not 5) tail callee is a sloppy/strict/possibly eval/bound/proxy function 6) tail calling via normal call/function.apply/function.call BUG=v8:4698 LOG=N Committed: https://crrev.com/7624465b618a2d230e784aebe3d8b594a01dac29 Cr-Commit-Position: refs/heads/master@{#34143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -92 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/es6/tail-call-megatest.js View 4 chunks +201 lines, -84 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711863002/1
4 years, 10 months ago (2016-02-18 17:44:04 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 18:26:50 UTC) #5
Igor Sheludko
PTAL
4 years, 10 months ago (2016-02-19 08:05:17 UTC) #7
Benedikt Meurer
LGTM.
4 years, 10 months ago (2016-02-19 08:23:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711863002/1
4 years, 10 months ago (2016-02-19 08:38:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 08:39:38 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 08:40:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7624465b618a2d230e784aebe3d8b594a01dac29
Cr-Commit-Position: refs/heads/master@{#34143}

Powered by Google App Engine
This is Rietveld 408576698