Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1711863002: [es6] Fixed POSSIBLY_EVAL_CALL tail calls handling in Full codegen. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 2728 matching lines...) Expand 10 before | Expand all | Expand 10 after
2739 EmitResolvePossiblyDirectEval(arg_count); 2739 EmitResolvePossiblyDirectEval(arg_count);
2740 2740
2741 // Touch up the stack with the resolved function. 2741 // Touch up the stack with the resolved function.
2742 __ mov(Operand(esp, (arg_count + 1) * kPointerSize), eax); 2742 __ mov(Operand(esp, (arg_count + 1) * kPointerSize), eax);
2743 2743
2744 PrepareForBailoutForId(expr->EvalId(), NO_REGISTERS); 2744 PrepareForBailoutForId(expr->EvalId(), NO_REGISTERS);
2745 2745
2746 SetCallPosition(expr); 2746 SetCallPosition(expr);
2747 __ mov(edi, Operand(esp, (arg_count + 1) * kPointerSize)); 2747 __ mov(edi, Operand(esp, (arg_count + 1) * kPointerSize));
2748 __ Set(eax, arg_count); 2748 __ Set(eax, arg_count);
2749 __ Call(isolate()->builtins()->Call(), RelocInfo::CODE_TARGET); 2749 __ Call(isolate()->builtins()->Call(ConvertReceiverMode::kAny,
2750 expr->tail_call_mode()),
2751 RelocInfo::CODE_TARGET);
2750 RecordJSReturnSite(expr); 2752 RecordJSReturnSite(expr);
2751 // Restore context register. 2753 // Restore context register.
2752 __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset)); 2754 __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
2753 context()->DropAndPlug(1, eax); 2755 context()->DropAndPlug(1, eax);
2754 } 2756 }
2755 2757
2756 2758
2757 void FullCodeGenerator::VisitCallNew(CallNew* expr) { 2759 void FullCodeGenerator::VisitCallNew(CallNew* expr) {
2758 Comment cmnt(masm_, "[ CallNew"); 2760 Comment cmnt(masm_, "[ CallNew");
2759 // According to ECMA-262, section 11.2.2, page 44, the function 2761 // According to ECMA-262, section 11.2.2, page 44, the function
(...skipping 1665 matching lines...) Expand 10 before | Expand all | Expand 10 after
4425 Assembler::target_address_at(call_target_address, 4427 Assembler::target_address_at(call_target_address,
4426 unoptimized_code)); 4428 unoptimized_code));
4427 return OSR_AFTER_STACK_CHECK; 4429 return OSR_AFTER_STACK_CHECK;
4428 } 4430 }
4429 4431
4430 4432
4431 } // namespace internal 4433 } // namespace internal
4432 } // namespace v8 4434 } // namespace v8
4433 4435
4434 #endif // V8_TARGET_ARCH_IA32 4436 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698