Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1711683003: zlib: Remove Windows XP workaround for CPU feature detection (Closed)

Created:
4 years, 10 months ago by robert.bradford
Modified:
4 years, 10 months ago
Reviewers:
*agl
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

zlib: Remove Windows XP workaround for CPU feature detection XP didn't have InitOnceExecuteOnce() so it was necessary to implement an equivalent using atomic compare-and-swap. With XP support no longer necessary the CPU feature detection code can now use InitOnceExecuteOnce() directly. TEST=net_unittests(GZipUnitTest) BUG=587964 Committed: https://crrev.com/18ad5f3a40ceab583961ca5dc064e01900514c57 Cr-Commit-Position: refs/heads/master@{#377928}

Patch Set 1 #

Patch Set 2 : 80 char tidy up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -31 lines) Patch
M third_party/zlib/x86.c View 1 2 chunks +10 lines, -31 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711683003/1
4 years, 10 months ago (2016-02-18 18:35:08 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 19:39:50 UTC) #4
robert.bradford
Hi agl@ please could you take a look? If it's fine please CQ.
4 years, 10 months ago (2016-02-18 20:53:50 UTC) #8
robert.bradford
agl@ ping?
4 years, 10 months ago (2016-02-26 16:56:49 UTC) #9
robert.bradford
agl@ ping?
4 years, 10 months ago (2016-02-26 16:57:01 UTC) #10
agl
please wrap lines at 80 chars. Otherwise LGTM.
4 years, 10 months ago (2016-02-26 17:00:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711683003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711683003/20001
4 years, 10 months ago (2016-02-26 17:20:22 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-26 18:30:37 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 18:31:53 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/18ad5f3a40ceab583961ca5dc064e01900514c57
Cr-Commit-Position: refs/heads/master@{#377928}

Powered by Google App Engine
This is Rietveld 408576698