Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1711683002: remove legacy bitmap filter (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -80 lines) Patch
M src/core/SkBitmapFilter.h View 6 chunks +1 line, -32 lines 1 comment Download
M src/core/SkBitmapScaler.cpp View 3 chunks +2 lines, -48 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
caryclark
4 years, 10 months ago (2016-02-18 13:06:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711683002/1
4 years, 10 months ago (2016-02-18 13:06:33 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-18 13:06:34 UTC) #5
f(malita)
lgtm https://codereview.chromium.org/1711683002/diff/1/src/core/SkBitmapFilter.h File src/core/SkBitmapFilter.h (right): https://codereview.chromium.org/1711683002/diff/1/src/core/SkBitmapFilter.h#newcode114 src/core/SkBitmapFilter.h:114: Sk4f x = val.abs(); Hopefully no side effects?
4 years, 10 months ago (2016-02-18 13:43:04 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 13:45:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6b14c6b329fde5402ce7458d8261e80944279d06

Powered by Google App Engine
This is Rietveld 408576698