third_party/WebKit/Source/core/page/FocusController.h - Issue 1711673002: Do not use Node in FocusController, 2nd

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FocusController.h

Issue 1711673002: Do not use Node in FocusController, 2nd (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@focus-navigation-no-longer-shadowroot

Patch Set: fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/page/FocusController.h

diff --git a/third_party/WebKit/Source/core/page/FocusController.h b/third_party/WebKit/Source/core/page/FocusController.h

index bd7d5e3cae6420a22b218b0888e3828a78d5f1ab..1754787e7f1b2ae1285887e8b7c5807be9f6d18b 100644

--- a/third_party/WebKit/Source/core/page/FocusController.h

+++ b/third_party/WebKit/Source/core/page/FocusController.h

@@ -92,7 +92,7 @@ private:

bool advanceFocus(WebFocusType, bool initialFocus, InputDeviceCapabilities* sourceCapabilities = nullptr);

bool advanceFocusDirectionally(WebFocusType);

- bool advanceFocusInDocumentOrder(LocalFrame*, Node* startingNode, WebFocusType, bool initialFocus, InputDeviceCapabilities* sourceCapabilities);

+ bool advanceFocusInDocumentOrder(LocalFrame*, Element* start, WebFocusType, bool initialFocus, InputDeviceCapabilities* sourceCapabilities);

bool advanceFocusDirectionallyInContainer(Node* container, const LayoutRect& startingRect, WebFocusType);

void findFocusCandidateInContainer(Node& container, const LayoutRect& startingRect, WebFocusType, FocusCandidate& closest);

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/FocusController.cpp » ('j') | third_party/WebKit/Source/core/page/FocusController.cpp » ('J')