Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: third_party/WebKit/Source/core/page/FocusController.h

Issue 1711673002: Do not use Node in FocusController, 2nd (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@focus-navigation-no-longer-shadowroot
Patch Set: fix Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 85
86 DECLARE_TRACE(); 86 DECLARE_TRACE();
87 87
88 private: 88 private:
89 explicit FocusController(Page*); 89 explicit FocusController(Page*);
90 90
91 Element* findFocusableElement(WebFocusType, Element&); 91 Element* findFocusableElement(WebFocusType, Element&);
92 92
93 bool advanceFocus(WebFocusType, bool initialFocus, InputDeviceCapabilities* sourceCapabilities = nullptr); 93 bool advanceFocus(WebFocusType, bool initialFocus, InputDeviceCapabilities* sourceCapabilities = nullptr);
94 bool advanceFocusDirectionally(WebFocusType); 94 bool advanceFocusDirectionally(WebFocusType);
95 bool advanceFocusInDocumentOrder(LocalFrame*, Node* startingNode, WebFocusTy pe, bool initialFocus, InputDeviceCapabilities* sourceCapabilities); 95 bool advanceFocusInDocumentOrder(LocalFrame*, Element* start, WebFocusType, bool initialFocus, InputDeviceCapabilities* sourceCapabilities);
96 96
97 bool advanceFocusDirectionallyInContainer(Node* container, const LayoutRect& startingRect, WebFocusType); 97 bool advanceFocusDirectionallyInContainer(Node* container, const LayoutRect& startingRect, WebFocusType);
98 void findFocusCandidateInContainer(Node& container, const LayoutRect& starti ngRect, WebFocusType, FocusCandidate& closest); 98 void findFocusCandidateInContainer(Node& container, const LayoutRect& starti ngRect, WebFocusType, FocusCandidate& closest);
99 99
100 RawPtrWillBeMember<Page> m_page; 100 RawPtrWillBeMember<Page> m_page;
101 RefPtrWillBeMember<Frame> m_focusedFrame; 101 RefPtrWillBeMember<Frame> m_focusedFrame;
102 bool m_isActive; 102 bool m_isActive;
103 bool m_isFocused; 103 bool m_isFocused;
104 bool m_isChangingFocusedFrame; 104 bool m_isChangingFocusedFrame;
105 }; 105 };
106 106
107 } // namespace blink 107 } // namespace blink
108 108
109 #endif // FocusController_h 109 #endif // FocusController_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698