Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: content/common/gpu/gpu_command_buffer_stub.cc

Issue 1711533002: Decouple browser-specific GPU IPC messages from GPU service IPCs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Mark's nit Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/gpu_command_buffer_stub.cc
diff --git a/content/common/gpu/gpu_command_buffer_stub.cc b/content/common/gpu/gpu_command_buffer_stub.cc
index 61512aaffa1cf9591157723301e12993ba948bc1..4650685fda51c2950010b3b2e790d72805c77741 100644
--- a/content/common/gpu/gpu_command_buffer_stub.cc
+++ b/content/common/gpu/gpu_command_buffer_stub.cc
@@ -18,6 +18,7 @@
#include "build/build_config.h"
#include "content/common/gpu/gpu_channel.h"
#include "content/common/gpu/gpu_channel_manager.h"
+#include "content/common/gpu/gpu_channel_manager_delegate.h"
#include "content/common/gpu/gpu_memory_manager.h"
#include "content/common/gpu/gpu_memory_tracking.h"
#include "content/common/gpu/gpu_messages.h"
@@ -471,10 +472,8 @@ void GpuCommandBufferStub::Destroy() {
if (initialized_) {
GpuChannelManager* gpu_channel_manager = channel_->gpu_channel_manager();
- if (handle_.is_null() && !active_url_.is_empty()) {
- gpu_channel_manager->Send(
- new GpuHostMsg_DidDestroyOffscreenContext(active_url_));
- }
+ if (handle_.is_null() && !active_url_.is_empty())
+ gpu_channel_manager->delegate()->DidDestroyOffscreenContext(active_url_);
}
if (decoder_)
@@ -674,10 +673,8 @@ void GpuCommandBufferStub::OnInitialize(
reply_message, true, capabilities);
Send(reply_message);
- if (handle_.is_null() && !active_url_.is_empty()) {
- manager->Send(new GpuHostMsg_DidCreateOffscreenContext(
- active_url_));
- }
+ if (handle_.is_null() && !active_url_.is_empty())
+ manager->delegate()->DidCreateOffscreenContext(active_url_);
initialized_ = true;
}
@@ -740,8 +737,8 @@ void GpuCommandBufferStub::OnParseError() {
// determine whether client APIs like WebGL need to be immediately
// blocked from automatically running.
GpuChannelManager* gpu_channel_manager = channel_->gpu_channel_manager();
- gpu_channel_manager->Send(new GpuHostMsg_DidLoseContext(
- handle_.is_null(), state.context_lost_reason, active_url_));
+ gpu_channel_manager->delegate()->DidLoseContext(
+ handle_.is_null(), state.context_lost_reason, active_url_);
CheckContextLost();
}

Powered by Google App Engine
This is Rietveld 408576698