Implement WebFrameClient in RenderFrame and proxy all calls to RenderView (for now).

content/renderer/render_frame_impl.h

Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 378ec0668f18129b705ad993c668c3d551eaffa2..c1f1f2869d666c48bc56d1d8b890262396fe7d57 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -19,7 +19,15 @@ class CONTENT_EXPORT RenderFrameImpl
     : public RenderFrame,
       NON_EXPORTED_BASE(public WebKit::WebFrameClient) {
  public:
-  RenderFrameImpl(RenderViewImpl* render_view, int routing_id);
+  // Creates a new RenderFrame. |render_view| is the RenderView object that this
+  // frame belongs to.
+  static RenderFrameImpl* Create(RenderViewImpl* render_view, int32 routing_id);
+
+  // Used by content_layouttest_support to hook into the creation of
+  // RenderFrameImpls.
+  static void InstallCreateHook(
+      RenderFrameImpl* (*create_render_frame_impl)(RenderViewImpl*, int32));

[jam, 2013/06/20 19:25:39]

nit: why isn't this a callback?

[nasko, 2013/06/20 20:25:42]

In general, I've tried to keep the same pattern that is used with RenderViewImpl
for consistency.

[jam, 2013/06/20 21:40:09]

ah. just saw that. is that RVImpl one going away after this one?
it would just be nice to use callbacks as that's the standard way now in chrome
code. but i dont feel strongly about it

+
   virtual ~RenderFrameImpl();
 
   // IPC::Sender
@@ -208,6 +216,9 @@ class CONTENT_EXPORT RenderFrameImpl
   // RenderFrameImpl methods
   int routing_id() { return routing_id_; }
 
+ protected:
+  RenderFrameImpl(RenderViewImpl* render_view, int32 routing_id);
+
  private:
   RenderViewImpl* render_view_;
   int routing_id_;