Implement WebFrameClient in RenderFrame and proxy all calls to RenderView (for now).

content/renderer/render_frame_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 
 #include "base/basictypes.h"
 #include "content/public/renderer/render_frame.h"
 #include "ipc/ipc_message.h"
 #include "third_party/WebKit/public/web/WebDataSource.h"
 #include "third_party/WebKit/public/web/WebFrameClient.h"
 
 namespace content {
 
 class RenderViewImpl;
 
 class CONTENT_EXPORT RenderFrameImpl
     : public RenderFrame,
       NON_EXPORTED_BASE(public WebKit::WebFrameClient) {
  public:
-  RenderFrameImpl(RenderViewImpl* render_view, int routing_id);
+  // Creates a new RenderFrame. |render_view| is the RenderView object that this
+  // frame belongs to.
+  static RenderFrameImpl* Create(RenderViewImpl* render_view, int32 routing_id);
+
+  // Used by content_layouttest_support to hook into the creation of
+  // RenderFrameImpls.
+  static void InstallCreateHook(
+      RenderFrameImpl* (*create_render_frame_impl)(RenderViewImpl*, int32));

[jam, 2013/06/20 19:25:39]

nit: why isn't this a callback?

[nasko, 2013/06/20 20:25:42]

In general, I've tried to keep the same pattern that is used with RenderViewImpl
for consistency.

[jam, 2013/06/20 21:40:09]

ah. just saw that. is that RVImpl one going away after this one?
it would just be nice to use callbacks as that's the standard way now in chrome
code. but i dont feel strongly about it

+
   virtual ~RenderFrameImpl();
 
   // IPC::Sender
   virtual bool Send(IPC::Message* msg) OVERRIDE;
 
   // IPC::Listener
   virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE;
 
   // WebKit::WebFrameClient implementation -------------------------------------
   virtual WebKit::WebPlugin* createPlugin(
@@ skipping 168 matching lines @@
       WebKit::WebFrame* frame,
       const WebKit::WebURL& url) OVERRIDE;
   virtual WebKit::WebString doNotTrackValue(WebKit::WebFrame* frame) OVERRIDE;
   virtual bool allowWebGL(WebKit::WebFrame* frame, bool default_value) OVERRIDE;
   virtual void didLoseWebGLContext(WebKit::WebFrame* frame,
                                    int arb_robustness_status_code) OVERRIDE;
 
   // RenderFrameImpl methods
   int routing_id() { return routing_id_; }
 
+ protected:
+  RenderFrameImpl(RenderViewImpl* render_view, int32 routing_id);
+
  private:
   RenderViewImpl* render_view_;
   int routing_id_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_