Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4462)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 17112021: New method: InputMethod::IsCandidatePopupOpen() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view.cc ('k') | ui/base/ime/dummy_input_method.h » ('j') | ui/base/ime/input_method_tsf.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
old mode 100644
new mode 100755
index c1ba44c4ada92a277c4f46733065852bf3a64f25..fa292d1860277fd750fcf055467a1a0a04762d4c
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -585,10 +585,9 @@ bool OmniboxViewViews::IsImeShowingPopup() const {
#if defined(OS_CHROMEOS)
return ime_candidate_window_open_;
#else
- // TODO(yukishiino): Implement detection of candidate windows on Windows.
- // We can detect whether any candidate window is open or not on Windows.
- // Currently we simply fall back to IsImeComposing() as a second best way.
- return IsImeComposing();
+ views::InputMethod* input_method =
+ const_cast<OmniboxViewViews*>(this)->GetInputMethod();
+ return input_method && input_method->IsPopupOpen();
#endif
}
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view.cc ('k') | ui/base/ime/dummy_input_method.h » ('j') | ui/base/ime/input_method_tsf.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698