chrome/browser/ui/omnibox/omnibox_view.cc - Issue 17112021: New method: InputMethod::IsCandidatePopupOpen()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_view.cc

Issue 17112021: New method: InputMethod::IsCandidatePopupOpen() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/omnibox/omnibox_view.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_view.cc b/chrome/browser/ui/omnibox/omnibox_view.cc

index 86b5bdda5e64dc129f39d9432bde5e54e890da1d..0d1d5a597734176bf8d696470ea8efea51371fde 100644

--- a/chrome/browser/ui/omnibox/omnibox_view.cc

+++ b/chrome/browser/ui/omnibox/omnibox_view.cc

@@ -129,8 +129,8 @@ void OmniboxView::CloseOmniboxPopup() {

bool OmniboxView::IsImeShowingPopup() const {

// Since not all the IMEs/platforms support the detection of a IME's popup

- // window, falls back to IsImeComposing().

- return IsImeComposing();

+ // window, returns false if unsure.

+ return false;

}

OmniboxView::OmniboxView(Profile* profile,