Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: tests/compiler/dart2js/list_tracer_node_type_test.dart

Issue 17112020: Fix an off by one AST node error, when fetching the type of a new List constructor. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/list_tracer_node_type_test.dart
===================================================================
--- tests/compiler/dart2js/list_tracer_node_type_test.dart (revision 0)
+++ tests/compiler/dart2js/list_tracer_node_type_test.dart (revision 0)
@@ -0,0 +1,48 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import "package:expect/expect.dart";
+import 'compiler_helper.dart';
+
+const String TEST1 = r"""
+main() {
+ var a = [42, null];
+ return a[0] + 42;
+}
+""";
+
+const String TEST2 = r"""
+main() {
+ var a = new List();
+ a.add(42);
+ a.add(null);
+ return a[0] + 42;
+}
+""";
+
+const String TEST3 = r"""
+main() {
+ var a = new List(42);
+ a[0] = 42;
+ return a[0] + 42;
+}
+""";
+
+
+main() {
+ String generated = compileAll(TEST1);
+ // Check that we only do a null check on the receiver for
+ // [: a[0] + 42 :]. We can do a null check because we inferred that
+ // the list is of type int or null.
+ Expect.isFalse(generated.contains('if (typeof t1'));
+ Expect.isTrue(generated.contains('if (t1 == null)'));
+
+ generated = compileAll(TEST2);
+ Expect.isFalse(generated.contains('if (typeof t1'));
+ Expect.isTrue(generated.contains('if (t1 == null)'));
+
+ generated = compileAll(TEST3);
+ Expect.isFalse(generated.contains('if (typeof t1'));
+ Expect.isTrue(generated.contains('if (t1 == null)'));
+}
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698