Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 17112020: Fix an off by one AST node error, when fetching the type of a new List constructor. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/list_tracer_node_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 24140)
+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)
@@ -3351,13 +3351,13 @@
originalElement, send, compiler)) {
isListConstructor = true;
HType inferred =
- new HType.inferredForNode(currentElement, node, compiler);
+ new HType.inferredForNode(currentElement, send, compiler);
return inferred.isUnknown() ? backend.fixedArrayType : inferred;
} else if (Elements.isGrowableListConstructorCall(
originalElement, send, compiler)) {
isListConstructor = true;
HType inferred =
- new HType.inferredForNode(currentElement, node, compiler);
+ new HType.inferredForNode(currentElement, send, compiler);
return inferred.isUnknown() ? backend.extendableArrayType : inferred;
} else if (element.isGenerativeConstructor()) {
ClassElement cls = element.getEnclosingClass();
« no previous file with comments | « no previous file | tests/compiler/dart2js/list_tracer_node_type_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698