Remove more things

Remove more things

(stripped) dart_product before: 5307888
(stripped) dart_product after: 5275088

Reduction in size: 32800 bytes.

Removed entirely:

- debuginfo*
- elfgen*
- gdbjit*
- TraceBuffer
- vtune support

Removed in product:

- Compiler stats
- Code observers

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/fda3a9bc2b66f68fc4ff8e7d241ec8366ab0a134

[Cutch, 2016-02-18 22:07:34]

Description was changed from

==========
Remove more things

BUG=
==========

to

==========
Remove more things

Remove more things

Removed entirely:

Removed in product:
==========

[Cutch, 2016-02-18 22:07:35]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2016-02-18 22:10:16]

Description was changed from

==========
Remove more things

Remove more things

Removed entirely:

Removed in product:
==========

to

==========
Remove more things

Removed entirely:

- debuginfo*
- elfgen*
- gdbjit*
- TraceBuffer
- vtune support

Removed in product:

- Compiler stats
- Code observers
==========

[Cutch, 2016-02-18 22:11:40]

Description was changed from

==========
Remove more things

Removed entirely:

- debuginfo*
- elfgen*
- gdbjit*
- TraceBuffer
- vtune support

Removed in product:

- Compiler stats
- Code observers
==========

to

==========
Remove more things

(stripped) dart_product before: 5307888
(stripped) dart_product after: 5275088

Reduction in size: 32800 bytes.

Removed entirely:

- debuginfo*
- elfgen*
- gdbjit*
- TraceBuffer
- vtune support

Removed in product:

- Compiler stats
- Code observers
==========

[Cutch, 2016-02-18 22:11:41]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com
- rmacnak@google.com

[siva, 2016-02-18 23:34:03]

lgtm

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/benchmark_test.cc
File runtime/vm/benchmark_test.cc (right):

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/benchmark_test.c...
runtime/vm/benchmark_test.cc:403: #endif  // !PRODUCT
Could we move this up inside the #ifndef PRODUCT block above (avoids too many
#ifndef stuff).

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/code_observers.h
File runtime/vm/code_observers.h (right):

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/code_observers.h...
runtime/vm/code_observers.h:13: class Mutex;
This could move under #ifndef PRODUCT too?

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/dart.cc#newcode112
runtime/vm/dart.cc:112: #endif
Can we move this up so that it is in the same block as TimelineDurationScope ?

[Cutch, 2016-02-22 16:05:44]

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/benchmark_test.cc
File runtime/vm/benchmark_test.cc (right):

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/benchmark_test.c...
runtime/vm/benchmark_test.cc:403: #endif  // !PRODUCT
On 2016/02/18 23:34:02, siva wrote:
> Could we move this up inside the #ifndef PRODUCT block above (avoids too many
> #ifndef stuff).

Done.

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/code_observers.h
File runtime/vm/code_observers.h (right):

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/code_observers.h...
runtime/vm/code_observers.h:13: class Mutex;
On 2016/02/18 23:34:03, siva wrote:
> This could move under #ifndef PRODUCT too?

Done.

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/dart.cc#newcode112
runtime/vm/dart.cc:112: #endif
On 2016/02/18 23:34:03, siva wrote:
> Can we move this up so that it is in the same block as TimelineDurationScope ?

I've used the new NOT_IN_PRODUCT macro.

[Cutch, 2016-02-22 16:53:15]

Description was changed from

==========
Remove more things

(stripped) dart_product before: 5307888
(stripped) dart_product after: 5275088

Reduction in size: 32800 bytes.

Removed entirely:

- debuginfo*
- elfgen*
- gdbjit*
- TraceBuffer
- vtune support

Removed in product:

- Compiler stats
- Code observers
==========

to

==========
Remove more things

(stripped) dart_product before: 5307888
(stripped) dart_product after: 5275088

Reduction in size: 32800 bytes.

Removed entirely:

- debuginfo*
- elfgen*
- gdbjit*
- TraceBuffer
- vtune support

Removed in product:

- Compiler stats
- Code observers

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fda3a9bc2b66f68fc4ff8e7d241ec8366ab0a134
==========

[Cutch, 2016-02-22 16:53:16]

Committed patchset #1 (id:1) manually as
fda3a9bc2b66f68fc4ff8e7d241ec8366ab0a134 (presubmit successful).

[Vyacheslav Egorov (Google), 2016-05-10 09:24:15]

vegorov@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2016-05-10 09:24:16]

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/os_linux.cc
File runtime/vm/os_linux.cc (left):

https://codereview.chromium.org/1711163002/diff/1/runtime/vm/os_linux.cc#oldc...
runtime/vm/os_linux.cc:133: class JitdumpCodeObserver : public CodeObserver {
How I am supposed to profile JIT code with CPU counters now? 

Observatory is a poor replacement for this.

[Cutch, 2016-05-10 20:52:15]

On 2016/05/10 09:24:16, Vyacheslav Egorov (Google) wrote:
> https://codereview.chromium.org/1711163002/diff/1/runtime/vm/os_linux.cc
> File runtime/vm/os_linux.cc (left):
> 
>
https://codereview.chromium.org/1711163002/diff/1/runtime/vm/os_linux.cc#oldc...
> runtime/vm/os_linux.cc:133: class JitdumpCodeObserver : public CodeObserver {
> How I am supposed to profile JIT code with CPU counters now? 
> 

We removed it because we thought no one was using it, feel free to add it back.