Remove more things

runtime/vm/dart.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/dart.h"
 
 #include "vm/code_observers.h"
 #include "vm/cpu.h"
 #include "vm/dart_api_state.h"
 #include "vm/dart_entry.h"
@@ skipping 89 matching lines @@
     Timeline::InitOnce();
   }
 #ifndef PRODUCT
   TimelineDurationScope tds(Timeline::GetVMStream(),
                             "Dart::InitOnce");
 #endif
   Isolate::InitOnce();
   PortMap::InitOnce();
   FreeListElement::InitOnce();
   Api::InitOnce();
+#ifndef PRODUCT
   CodeObservers::InitOnce();
+#endif

[siva, 2016/02/18 23:34:03]

Can we move this up so that it is in the same block as TimelineDurationScope ?

[Cutch, 2016/02/22 16:05:44]

I've used the new NOT_IN_PRODUCT macro.

   if (FLAG_profiler) {
     ThreadInterrupter::InitOnce();
     Profiler::InitOnce();
   }
   SemiSpace::InitOnce();
   Metric::InitOnce();
   StoreBuffer::InitOnce();
   MarkingStack::InitOnce();
 
 #if defined(USING_SIMULATOR)
@@ skipping 237 matching lines @@
       OS::PrintErr("[+%" Pd64 "ms] SHUTDOWN: Disabling OS Thread creation\n",
                    timestamp());
     }
     OSThread::DisableOSThreadCreation();
   }
 
   if (FLAG_trace_shutdown) {
     OS::PrintErr("[+%" Pd64 "ms] SHUTDOWN: Deleting code observers\n",
                  timestamp());
   }
+#ifndef PRODUCT
   CodeObservers::DeleteAll();
+#endif  // !PRODUCT
   if (FLAG_support_timeline) {
     if (FLAG_trace_shutdown) {
       OS::PrintErr("[+%" Pd64 "ms] SHUTDOWN: Shutting down timeline\n",
                    timestamp());
     }
     Timeline::Shutdown();
   }
   if (FLAG_trace_shutdown) {
     OS::PrintErr("[+%" Pd64 "ms] SHUTDOWN: Done\n", timestamp());
   }
@@ skipping 185 matching lines @@
   return predefined_handles_->handles_.IsValidScopedHandle(address);
 }
 
 
 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
   ASSERT(predefined_handles_ != NULL);
   return predefined_handles_->api_handles_.IsValidHandle(handle);
 }
 
 }  // namespace dart