Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 1711103002: Implement lifetime observer on RenderWidgetHostViewBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restructure, and make RWHVB derived classes responsible for early notification. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index 9a2e25bcc2b04abc937a4dd588c51b04d152236b..8b27c7a9af267cb1560c5fc2a949066a88e47312 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -14,6 +14,7 @@
#include "base/callback_forward.h"
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
+#include "base/observer_list.h"
#include "base/process/kill.h"
#include "base/timer/timer.h"
#include "build/build_config.h"
@@ -62,6 +63,7 @@ class LatencyInfo;
namespace content {
class BrowserAccessibilityDelegate;
class BrowserAccessibilityManager;
+class RenderWidgetHostViewBaseObserver;
class SyntheticGesture;
class SyntheticGestureTarget;
class WebCursor;
@@ -388,10 +390,18 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
static void DetachPluginWindowsCallback(HWND window);
#endif
+ // Add and remove observers for lifetime event notifications. The order in
+ // which notifications are sent to observers is undefined. Clients must be
+ // sure to remove the observer before they go away.
+ void AddObserver(RenderWidgetHostViewBaseObserver* observer);
+ void RemoveObserver(RenderWidgetHostViewBaseObserver* observer);
+
protected:
// Interface class only, do not construct.
RenderWidgetHostViewBase();
+ void NotifyObserversAboutShutdown();
+
#if defined(OS_WIN)
// Shared implementation of MovePluginWindows for use by win and aura/wina.
static void MovePluginWindowsHelper(
@@ -454,6 +464,8 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
base::OneShotTimer flush_input_timer_;
+ base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;
+
base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);

Powered by Google App Engine
This is Rietveld 408576698