Implement lifetime observer on RenderWidgetHostViewBase.

content/browser/renderer_host/render_widget_host_view_base.cc

Index: content/browser/renderer_host/render_widget_host_view_base.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc
index 780ced5af6016c192761f09227148b61bae5ff28..6fdb88a19d850f94da9c216721347fff421231e3 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.cc
+++ b/content/browser/renderer_host/render_widget_host_view_base.cc
@@ -11,6 +11,7 @@
 #include "content/browser/renderer_host/input/synthetic_gesture_target_base.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
+#include "content/browser/renderer_host/render_widget_host_view_base_observer.h"
 #include "content/common/content_switches_internal.h"
 #include "content/public/browser/render_widget_host_view_frame_subscriber.h"
 #include "ui/gfx/display.h"
@@ -377,11 +378,28 @@ RenderWidgetHostViewBase::RenderWidgetHostViewBase()
       current_display_rotation_(gfx::Display::ROTATE_0),
       pinch_zoom_enabled_(content::IsPinchToZoomEnabled()),
       renderer_frame_number_(0),
-      weak_factory_(this) {
-}
+      weak_factory_(this) {}
 
 RenderWidgetHostViewBase::~RenderWidgetHostViewBase() {
   DCHECK(!mouse_locked_);
+  // We call this here to guarantee that observers are notified before we go
+  // away. However, some subclasses may wish to call this earlier in their
+  // shutdown process, e.g. to force removal from
+  // RenderWidgetHostInputEventRouter's surface map before relinquishing a
+  // host pointer, as in RenderWidgetHostViewGuest. There is no harm in calling
+  // NotifyObserversAboutShutdown() twice, as the observers are required to
+  // de-register on the first call, and so the second call does nothing.

[kenrb, 2016/02/22 17:05:10]

Do you know of any case where this is actually needed?

[wjmaclean, 2016/02/23 13:13:26]

My hope was that, by putting this here, then only sub-classes with special needs
around notifying earlier (e.g. RWHVCF, RWHVG, RWHVMac) would have to make
earlier calls, and all other sub-classes could just default to having it called
here.

+  NotifyObserversAboutShutdown();
+}
+
+void RenderWidgetHostViewBase::NotifyObserversAboutShutdown() {
+  // Note: RenderWidgetHostInputEventRouter is an observer, and uses the
+  // following notification to remove this view from its surface owners map.
+  FOR_EACH_OBSERVER(RenderWidgetHostViewBaseObserver,
+                    observers_,
+                    OnRenderWidgetHostViewBaseDestroyed(this));
+  // All observers are required to disconnect after they are notified.
+  DCHECK(!observers_.might_have_observers());
 }
 
 bool RenderWidgetHostViewBase::OnMessageReceived(const IPC::Message& msg){
@@ -701,4 +719,14 @@ void RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
   *transformed_point = point;
 }
 
+void RenderWidgetHostViewBase::AddObserver(
+    RenderWidgetHostViewBaseObserver* observer) {
+  observers_.AddObserver(observer);
+}
+
+void RenderWidgetHostViewBase::RemoveObserver(
+    RenderWidgetHostViewBaseObserver* observer) {
+  observers_.RemoveObserver(observer);
+}
+
 }  // namespace content