Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1710913004: Set hasImplicitReturnType for variable initializer functions. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set hasImplicitReturnType for variable initializer functions. This will make summary generation for these functions easier, since it will allow us to re-use most of the logic for storing inferred types when storing their return types. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/d5d5dae61f03f21a54bed21b68346b5f334f4267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 5 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-18 17:02:57 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-18 17:06:41 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-18 17:07:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d5d5dae61f03f21a54bed21b68346b5f334f4267 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698