Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Side by Side Diff: pkg/analyzer/lib/src/summary/resynthesize.dart

Issue 1710913004: Set hasImplicitReturnType for variable initializer functions. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library summary_resynthesizer; 5 library summary_resynthesizer;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 8
9 import 'package:analyzer/dart/ast/ast.dart'; 9 import 'package:analyzer/dart/ast/ast.dart';
10 import 'package:analyzer/dart/ast/token.dart'; 10 import 'package:analyzer/dart/ast/token.dart';
(...skipping 1746 matching lines...) Expand 10 before | Expand all | Expand 10 after
1757 * If the given [serializedInitializer] is not `null`, create the 1757 * If the given [serializedInitializer] is not `null`, create the
1758 * corresponding [FunctionElementImpl] and set it for the [variable]. 1758 * corresponding [FunctionElementImpl] and set it for the [variable].
1759 */ 1759 */
1760 void buildVariableInitializer( 1760 void buildVariableInitializer(
1761 VariableElementImpl variable, UnlinkedExecutable serializedInitializer) { 1761 VariableElementImpl variable, UnlinkedExecutable serializedInitializer) {
1762 if (serializedInitializer == null) { 1762 if (serializedInitializer == null) {
1763 return null; 1763 return null;
1764 } 1764 }
1765 FunctionElementImpl initializerElement = 1765 FunctionElementImpl initializerElement =
1766 buildLocalFunction(serializedInitializer); 1766 buildLocalFunction(serializedInitializer);
1767 // TODO(scheglov) The flag `hasImplicitReturnType` is `true` now because we
1768 // don't serialize the return type. But once we do, the next two statements
1769 // can be removed.
1770 assert(initializerElement.hasImplicitReturnType == true);
1771 initializerElement.hasImplicitReturnType = false;
1772 initializerElement.synthetic = true; 1767 initializerElement.synthetic = true;
1773 variable.initializer = initializerElement; 1768 variable.initializer = initializerElement;
1774 } 1769 }
1775 1770
1776 /** 1771 /**
1777 * Finish creating a [TypeParameterElement] by deserializing its bound. 1772 * Finish creating a [TypeParameterElement] by deserializing its bound.
1778 */ 1773 */
1779 void finishTypeParameter(UnlinkedTypeParam serializedTypeParameter, 1774 void finishTypeParameter(UnlinkedTypeParam serializedTypeParameter,
1780 TypeParameterElementImpl typeParameterElement) { 1775 TypeParameterElementImpl typeParameterElement) {
1781 if (serializedTypeParameter.bound != null) { 1776 if (serializedTypeParameter.bound != null) {
(...skipping 450 matching lines...) Expand 10 before | Expand all | Expand 10 after
2232 } 2227 }
2233 : () => this.element; 2228 : () => this.element;
2234 // TODO(paulberry): Is it a bug that we have to pass `false` for 2229 // TODO(paulberry): Is it a bug that we have to pass `false` for
2235 // isInstantiated? 2230 // isInstantiated?
2236 return new DeferredFunctionTypeImpl(computer, null, typeArguments, false); 2231 return new DeferredFunctionTypeImpl(computer, null, typeArguments, false);
2237 } else { 2232 } else {
2238 return null; 2233 return null;
2239 } 2234 }
2240 } 2235 }
2241 } 2236 }
OLDNEW
« no previous file with comments | « pkg/analyzer/lib/src/dart/element/builder.dart ('k') | pkg/analyzer/test/generated/all_the_rest_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698