Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1710893003: Revert of Change Event.deepPath to a method (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
yuzuchan, hayato, kojii, samli, kochi
CC:
blink-reviews, chromium-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change Event.deepPath to a method (patchset #4 id:60001 of https://codereview.chromium.org/1637813002/ ) Reason for revert: Breaks devtools. Landed without devtools review. Original issue's description: > Change Event.deepPath to a method > > In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. > See the discussion here: https://github.com/w3c/webcomponents/issues/361 > Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget > See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c > BUG=531990 > > Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 > Cr-Commit-Position: refs/heads/master@{#372596} > > Committed: https://crrev.com/074da65f2d82b187dc44c5c5be09d3fec100d63d > Cr-Commit-Position: refs/heads/master@{#376103} TBR=samli@chromium.org,hayato@chromium.org,kochi@chromium.org,kojii@chromium.org,yuzus@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=531990 Committed: https://crrev.com/02d38b39363add3ad9dd401f71cb4b1cf704e892 Cr-Commit-Position: refs/heads/master@{#376223}

Patch Set 1 #

Messages

Total messages: 6 (1 generated)
pfeldman
Created Revert of Change Event.deepPath to a method
4 years, 10 months ago (2016-02-18 18:54:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710893003/1
4 years, 10 months ago (2016-02-18 18:57:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710893003/1
4 years, 10 months ago (2016-02-18 19:05:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 19:17:28 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 19:18:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02d38b39363add3ad9dd401f71cb4b1cf704e892
Cr-Commit-Position: refs/heads/master@{#376223}

Powered by Google App Engine
This is Rietveld 408576698