Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1710373002: Revert Move VideoCapture* files from media/base/android/... to media/capture/video/android/java/... (Closed)

Created:
4 years, 10 months ago by clamy
Modified:
4 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, Peter Beverloo, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mlamouri+watch-media_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move VideoCapture* files from media/base/android/... to media/capture/video/android/java/... (patchset #2 id:70001 of https://codereview.chromium.org/1705333003/ ) Reason for revert: Android WebView tests started failing after 4 CLs landed including this one, and it seems like the most likely culprit. See https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20L%20%28dbg%29/builds/9568 and https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20M%20%28dbg%29/builds/5214. Original issue's description: > Move VideoCapture* files from media/base/android/... to media/capture/video/android/java/... > > ** No code changes (except git cl format kicked by presbumit). ** > > This CL refactors the VideoCapture*java classes > from being under media/base/android/java/... into > media/capture/video/android/java/... with the idea > of bringing all such classes under a single roof > as a preparation for http://crbug.com/584797 (CL > http://crrev.com/1699553002) which creates an entity > (very similar to media/cast/ and media/midi/) with > its own .gn and .gyp. > > BUG=587693, 584797 > NOTRY=true > > Committed: https://crrev.com/157c17e6d77e64efee6b82947506f544aac3b79f > Cr-Commit-Position: refs/heads/master@{#376409} TBR=qinmin@chromium.org,dalecurtis@chromium.org,avi@chromium.org,dtrainor@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587693, 584797 Committed: https://crrev.com/5f5cab50b44307c6ce1fde3d1a7b13be913d3304 Cr-Commit-Position: refs/heads/master@{#376438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1552 lines, -1505 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/android/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/VideoCapture.java View 1 chunk +126 lines, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java View 1 chunk +183 lines, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/VideoCaptureCamera.java View 1 chunk +294 lines, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 1 chunk +503 lines, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java View 1 chunk +172 lines, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/VideoCaptureFormat.java View 1 chunk +36 lines, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/VideoCaptureTango.java View 1 chunk +197 lines, -0 lines 0 comments Download
D media/capture/video/android/BUILD.gn View 1 chunk +0 lines, -36 lines 0 comments Download
D media/capture/video/android/java/src/org/chromium/media/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D media/capture/video/android/java/src/org/chromium/media/VideoCapture.java View 1 chunk +0 lines, -120 lines 0 comments Download
D media/capture/video/android/java/src/org/chromium/media/VideoCaptureAndroid.java View 1 chunk +0 lines, -174 lines 0 comments Download
D media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java View 1 chunk +0 lines, -286 lines 0 comments Download
D media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 1 chunk +0 lines, -491 lines 0 comments Download
D media/capture/video/android/java/src/org/chromium/media/VideoCaptureFactory.java View 1 chunk +0 lines, -164 lines 0 comments Download
D media/capture/video/android/java/src/org/chromium/media/VideoCaptureFormat.java View 1 chunk +0 lines, -35 lines 0 comments Download
D media/capture/video/android/java/src/org/chromium/media/VideoCaptureTango.java View 1 chunk +0 lines, -185 lines 0 comments Download
M media/media.gyp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
clamy
Created Revert of Move VideoCapture* files from media/base/android/... to media/capture/video/android/java/...
4 years, 10 months ago (2016-02-19 14:37:50 UTC) #1
Avi (use Gerrit)
4 years, 10 months ago (2016-02-19 15:21:39 UTC) #3
Message was sent while issue was closed.
On 2016/02/19 14:37:50, clamy wrote:
> Created Revert of Move VideoCapture* files from media/base/android/... to
> media/capture/video/android/java/...

LGTM

Powered by Google App Engine
This is Rietveld 408576698