Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1710103003: Check for destroyed WebContents in getUrl (Closed)

Created:
4 years, 10 months ago by mnaganov (inactive)
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Check for destroyed WebContents in getUrl There seem to be crashes in WebContentsAndroid::GetURL probably caused by a bad native pointer coming from the Java side. BUG=587281 Review URL: https://codereview.chromium.org/1707503003 Cr-Commit-Position: refs/heads/master@{#375910} (cherry picked from commit b07e7b329c04c18dda0de66fe48ead648167ddb4) Committed: https://chromium.googlesource.com/chromium/src/+/687da4b00481027145d18c42653202aa4621f9f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mnaganov (inactive)
4 years, 10 months ago (2016-02-18 23:35:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
687da4b00481027145d18c42653202aa4621f9f4 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698