Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 1707503003: Check for destroyed WebContents in getUrl (Closed)

Created:
4 years, 10 months ago by mnaganov (inactive)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for destroyed WebContents in getUrl There seem to be crashes in WebContentsAndroid::GetURL probably caused by a bad native pointer coming from the Java side. BUG=587281 Committed: https://crrev.com/b07e7b329c04c18dda0de66fe48ead648167ddb4 Cr-Commit-Position: refs/heads/master@{#375910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mnaganov (inactive)
Hi David, PTAL!
4 years, 10 months ago (2016-02-17 01:28:38 UTC) #2
David Trainor- moved to gerrit
Should we do this for all methods in WebContents? I wonder why we're accessing a ...
4 years, 10 months ago (2016-02-17 15:25:39 UTC) #3
mnaganov (inactive)
On 2016/02/17 15:25:39, David Trainor wrote: > Should we do this for all methods in ...
4 years, 10 months ago (2016-02-17 16:21:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707503003/1
4 years, 10 months ago (2016-02-17 16:21:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 17:23:43 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 17:26:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b07e7b329c04c18dda0de66fe48ead648167ddb4
Cr-Commit-Position: refs/heads/master@{#375910}

Powered by Google App Engine
This is Rietveld 408576698