Chromium Code Reviews

Issue 1710043002: Start to unwind references to iOS in //content (Closed)

Created:
4 years, 10 months ago by blundell
Modified:
4 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start to unwind references to iOS in //content The iOS port no longer uses //content (hooray!). This CL starts the unwinding of references to iOS in //content by removing most references in gypfiles. Note that after this CL dependencies on the content_browser or content_common target will cause a gyp_chromium failure on iOS. This "fail fast" behavior is good since new dependencies on //content on iOS are wrong. Committed: https://crrev.com/e5ecd0f07adc12ac233d15a608d6bd3af569b2e4 Cr-Commit-Position: refs/heads/master@{#376494}

Patch Set 1 #

Patch Set 2 : Self-review #

Patch Set 3 : Rebase #

Patch Set 4 : Fixes #

Patch Set 5 : Android fix #

Unified diffs Side-by-side diffs Stats (+203 lines, -312 lines)
M build/gypi_to_gn.py View 1 chunk +11 lines, -12 lines 0 comments
M content/browser/BUILD.gn View 2 chunks +1 line, -8 lines 0 comments
M content/content.gyp View 5 chunks +101 lines, -123 lines 0 comments
M content/content_browser.gypi View 7 chunks +30 lines, -55 lines 0 comments
M content/content_child.gypi View 3 chunks +8 lines, -18 lines 0 comments
M content/content_common.gypi View 3 chunks +50 lines, -88 lines 0 comments
M content/content_shell_and_tests.gyp View 1 chunk +2 lines, -8 lines 0 comments

Messages

Total messages: 9 (4 generated)
blundell
4 years, 10 months ago (2016-02-19 14:03:55 UTC) #3
jam
lgtm
4 years, 10 months ago (2016-02-19 16:42:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710043002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710043002/80001
4 years, 10 months ago (2016-02-19 17:09:00 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-19 18:26:43 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 18:28:24 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e5ecd0f07adc12ac233d15a608d6bd3af569b2e4
Cr-Commit-Position: refs/heads/master@{#376494}

Powered by Google App Engine