Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1948)

Unified Diff: build/gypi_to_gn.py

Issue 1710043002: Start to unwind references to iOS in //content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android fix Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gypi_to_gn.py
diff --git a/build/gypi_to_gn.py b/build/gypi_to_gn.py
index 6de1a6385df9d8c4d4d1b5b59ce652f0d93463d6..a5175a406d21b1ac34becb537b29d8628ceb24f7 100644
--- a/build/gypi_to_gn.py
+++ b/build/gypi_to_gn.py
@@ -90,18 +90,17 @@ def LoadPythonDictionary(path):
file_data.update(file_data['variables'])
del file_data['variables']
- # Strip any conditions.
- if 'conditions' in file_data:
- del file_data['conditions']
- if 'target_conditions' in file_data:
- del file_data['target_conditions']
-
- # Strip targets and includes in the toplevel, since some files define these
- # and we can't slurp them in.
- if 'targets' in file_data:
- del file_data['targets']
- if 'includes' in file_data:
- del file_data['includes']
+ # Strip all elements that this script can't process.
+ elements_to_strip = [
+ 'conditions',
+ 'target_conditions',
+ 'targets',
+ 'includes',
+ 'actions',
+ ]
+ for element in elements_to_strip:
+ if element in file_data:
+ del file_data[element]
return file_data
« no previous file with comments | « no previous file | content/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698