[css-align] New CSS Value 'normal' for Self Alignment

third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
index 0b50bb5347f1ff2648cbbb8b3383d4e03dcb1452..0887479ab139dd6e4d53dc0560a74d1bbdeb7045 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
@@ -4340,6 +4340,9 @@ template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ItemPosition itemPosition
     case ItemPositionAuto:
         m_value.valueID = CSSValueAuto;

[Timothy Loh, 2016/06/29 02:00:32]

Not sure if this case is still reached, if not, add a NOT_REACHED()

[jfernandez, 2016/06/29 19:55:47]

Since we left unresolved the initial value of the Self Alignment properties
(justify-self, align-self) I can't ensure ItemPositionAuto is not reached. 

[Timothy Loh, 2016/06/30 01:50:05]

Isn't this only used by ComputedStyleCSSValueMapping though, where you're
explicitly handling this?

[jfernandez, 2016/06/30 10:17:53]

Yes, you are right. It's only used by the computed style mapping logic, so I
guess
we can add the assert as you suggested.  

         break;
+    case ItemPositionNormal:
+        m_value.valueID = CSSValueNormal;
+        break;
     case ItemPositionStretch:
         m_value.valueID = CSSValueStretch;
         break;
@@ -4384,6 +4387,8 @@ template<> inline ItemPosition CSSPrimitiveValue::convertTo() const
     switch (m_value.valueID) {
     case CSSValueAuto:
         return ItemPositionAuto;
+    case CSSValueNormal:
+        return ItemPositionNormal;
     case CSSValueStretch:
         return ItemPositionStretch;
     case CSSValueBaseline: