[css-align] New CSS Value 'normal' for Self Alignment

third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

 /*
  * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ skipping 4320 matching lines @@
     ASSERT_NOT_REACHED();
     return ContentBox;
 }
 
 template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ItemPosition itemPosition)
     : CSSValue(PrimitiveClass)
 {
     init(UnitType::ValueID);
     switch (itemPosition) {
     case ItemPositionAuto:
         m_value.valueID = CSSValueAuto;

[Timothy Loh, 2016/06/29 02:00:32]

Not sure if this case is still reached, if not, add a NOT_REACHED()

[jfernandez, 2016/06/29 19:55:47]

Since we left unresolved the initial value of the Self Alignment properties
(justify-self, align-self) I can't ensure ItemPositionAuto is not reached. 

[Timothy Loh, 2016/06/30 01:50:05]

Isn't this only used by ComputedStyleCSSValueMapping though, where you're
explicitly handling this?

[jfernandez, 2016/06/30 10:17:53]

Yes, you are right. It's only used by the computed style mapping logic, so I
guess
we can add the assert as you suggested.  

         break;
+    case ItemPositionNormal:
+        m_value.valueID = CSSValueNormal;
+        break;
     case ItemPositionStretch:
         m_value.valueID = CSSValueStretch;
         break;
     case ItemPositionBaseline:
         m_value.valueID = CSSValueBaseline;
         break;
     case ItemPositionLastBaseline:
         m_value.valueID = CSSValueLastBaseline;
         break;
     case ItemPositionCenter:
@@ skipping 24 matching lines @@
         m_value.valueID = CSSValueRight;
         break;
     }
 }
 
 template<> inline ItemPosition CSSPrimitiveValue::convertTo() const
 {
     switch (m_value.valueID) {
     case CSSValueAuto:
         return ItemPositionAuto;
+    case CSSValueNormal:
+        return ItemPositionNormal;
     case CSSValueStretch:
         return ItemPositionStretch;
     case CSSValueBaseline:
         return ItemPositionBaseline;
     case CSSValueLastBaseline:
         return ItemPositionLastBaseline;
     case CSSValueCenter:
         return ItemPositionCenter;
     case CSSValueStart:
         return ItemPositionStart;
@@ skipping 272 matching lines @@
     default:
         break;
     }
     ASSERT_NOT_REACHED();
     return ContainsNone;
 }
 
 } // namespace blink
 
 #endif