Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 1709963002: [css-align] New CSS Value 'normal' for Self Alignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: New test for alignment and anonymous boxes. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
index 0b50bb5347f1ff2648cbbb8b3383d4e03dcb1452..0887479ab139dd6e4d53dc0560a74d1bbdeb7045 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
@@ -4340,6 +4340,9 @@ template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ItemPosition itemPosition
case ItemPositionAuto:
m_value.valueID = CSSValueAuto;
Timothy Loh 2016/06/29 02:00:32 Not sure if this case is still reached, if not, ad
jfernandez 2016/06/29 19:55:47 Since we left unresolved the initial value of the
Timothy Loh 2016/06/30 01:50:05 Isn't this only used by ComputedStyleCSSValueMappi
jfernandez 2016/06/30 10:17:53 Yes, you are right. It's only used by the computed
break;
+ case ItemPositionNormal:
+ m_value.valueID = CSSValueNormal;
+ break;
case ItemPositionStretch:
m_value.valueID = CSSValueStretch;
break;
@@ -4384,6 +4387,8 @@ template<> inline ItemPosition CSSPrimitiveValue::convertTo() const
switch (m_value.valueID) {
case CSSValueAuto:
return ItemPositionAuto;
+ case CSSValueNormal:
+ return ItemPositionNormal;
case CSSValueStretch:
return ItemPositionStretch;
case CSSValueBaseline:

Powered by Google App Engine
This is Rietveld 408576698